[jboss-jira] [JBoss JIRA] (WFLY-10229) org.jboss.as.txn.service.internal.tsr.TransactionSynchronizationRegistryWrapper.getStatus() should use org.wildfly.transaction.client.ContextTransactionManager.getStatus()

[Scott Marlow (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560967#comment-13560967 ] 

Scott Marlow edited comment on WFLY-10229 at 4/13/18 10:15 AM:
---------------------------------------------------------------

Good point, for me, I didn't realize that WildFly TSR wrapper class was referencing the com.arjuna.ats.jta.TransactionManager instance directly still, which skips using the org.wildfly.transaction.client.ContextTransactionManager instance so I was thinking of that as the "why" as well, but *agreed* that is more of the "*how*.  :)

This is kind of dangerous that we won't know if an application is directly using com.arjuna.ats.jta.TransactionManager or org.wildfly.transaction.client.ContextTransactionManager, not that applications should directly use a TransactionManager but they might be.  Is this a valid concern?


was (Author: smarlow):
Good point, for me, I didn't realize that WildFly TSR wrapper class was referencing the com.arjuna.ats.jta.TransactionManager instance directly still, which skips using the org.wildfly.transaction.client.ContextTransactionManager instance so I was thinking of that as the "why" as well.  

This is kind of dangerous that we won't know if an application is directly using com.arjuna.ats.jta.TransactionManager or org.wildfly.transaction.client.ContextTransactionManager, not that applications should directly use a TransactionManager but they might be.  Is this a valid concern?

> org.jboss.as.txn.service.internal.tsr.TransactionSynchronizationRegistryWrapper.getStatus() should use org.wildfly.transaction.client.ContextTransactionManager.getStatus()
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WFLY-10229
>                 URL: https://issues.jboss.org/browse/WFLY-10229
>             Project: WildFly
>          Issue Type: Task
>          Components: Transactions
>            Reporter: Scott Marlow
>            Assignee: David Lloyd
>             Fix For: 13.0.0.Beta1
>
>
> org.jboss.as.txn.service.internal.tsr.TransactionSynchronizationRegistryWrapper.getStatus() is currently using com.arjuna.ats.jta.TransactionManager, instead it should use org.wildfly.transaction.client.ContextTransactionManager.getStatus().
> I'm seeing a case in Hibernate ORM 5.3, where org.wildfly.transaction.client.ContextTransactionManager.getStatus() returns 4 but TransactionSynchronizationRegistryWrapper.getStatus() returns 1.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)