[jboss-jira] [JBoss JIRA] (ELY-1564) In PasswordKeyMapper an exception is logged with a wrong algorithm name.

[Ilia Vassilev (JIRA)]

     [ https://issues.jboss.org/browse/ELY-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ilia Vassilev updated ELY-1564:
-------------------------------
    Description: 
In PasswordKeyMapper an exception is logged with the default algorithm name instead of the algorithm used to instantiate PasswordFactory object. 

{code:java|title=PasswordKeyMapper.java}
        final PasswordFactory passwordFactory;
        try {
            passwordFactory = PasswordFactory.getInstance(algorithmName, providers);
        } catch (NoSuchAlgorithmException e) {
            throw log.couldNotObtainPasswordFactoryForAlgorithm(algorithmName, e);
        }

...

        try {
            Password password = passwordFactory.generatePassword(passwordSpec);
            if (log.isTraceEnabled()) {
                log.tracef("Key Mapper: Password credential created using algorithm column value [%s]", algorithmName);
            }
            return new PasswordCredential(password);
        } catch (InvalidKeySpecException e) {
            throw log.invalidPasswordKeySpecificationForAlgorithm(this.defaultAlgorithm, e);
        }
{code}

  was:
In PasswordKeyMapper an exception is logged with the default algorithm name instead of the algorithm used to instantiate PasswordFactory object. 

{code}
        final PasswordFactory passwordFactory;
        try {
            passwordFactory = PasswordFactory.getInstance(algorithmName, providers);
        } catch (NoSuchAlgorithmException e) {
            throw log.couldNotObtainPasswordFactoryForAlgorithm(algorithmName, e);
        }
{code}
...
{code}
        try {
            Password password = passwordFactory.generatePassword(passwordSpec);
            if (log.isTraceEnabled()) {
                log.tracef("Key Mapper: Password credential created using algorithm column value [%s]", algorithmName);
            }
            return new PasswordCredential(password);
        } catch (InvalidKeySpecException e) {
            throw log.invalidPasswordKeySpecificationForAlgorithm(this.defaultAlgorithm, e);
        }
{code}



> In PasswordKeyMapper an exception is logged with a wrong algorithm name.
> ------------------------------------------------------------------------
>
>                 Key: ELY-1564
>                 URL: https://issues.jboss.org/browse/ELY-1564
>             Project: WildFly Elytron
>          Issue Type: Bug
>          Components: Authentication Mechanisms
>    Affects Versions: 1.2.4.Final
>            Reporter: Ilia Vassilev
>            Assignee: Ilia Vassilev
>            Priority: Minor
>
> In PasswordKeyMapper an exception is logged with the default algorithm name instead of the algorithm used to instantiate PasswordFactory object. 
> {code:java|title=PasswordKeyMapper.java}
>         final PasswordFactory passwordFactory;
>         try {
>             passwordFactory = PasswordFactory.getInstance(algorithmName, providers);
>         } catch (NoSuchAlgorithmException e) {
>             throw log.couldNotObtainPasswordFactoryForAlgorithm(algorithmName, e);
>         }
> ...
>         try {
>             Password password = passwordFactory.generatePassword(passwordSpec);
>             if (log.isTraceEnabled()) {
>                 log.tracef("Key Mapper: Password credential created using algorithm column value [%s]", algorithmName);
>             }
>             return new PasswordCredential(password);
>         } catch (InvalidKeySpecException e) {
>             throw log.invalidPasswordKeySpecificationForAlgorithm(this.defaultAlgorithm, e);
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)