[jboss-jira] [JBoss JIRA] (WFLY-2982) refactor two phase persistence unit services (PhaseOnePersistenceUnitServiceImpl + PersistenceUnitServiceImpl) into one service

[Scott Marlow (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-2982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616624#comment-13616624 ] 

Scott Marlow commented on WFLY-2982:
------------------------------------

Not sure if it is possible, but one way to refactor the two persistence unit services, into one, would be to not use services at all for starting the persistence unit.  

> refactor two phase persistence unit services (PhaseOnePersistenceUnitServiceImpl + PersistenceUnitServiceImpl) into one service
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WFLY-2982
>                 URL: https://issues.jboss.org/browse/WFLY-2982
>             Project: WildFly
>          Issue Type: Feature Request
>          Components: JPA / Hibernate
>    Affects Versions: 8.0.0.Final
>            Reporter: Scott Marlow
>            Assignee: Scott Marlow
>
> Related feedback from https://github.com/wildfly/wildfly/pull/4722:
> {quote}
> This is asymetrical, so if this service , and phase one are stopped, and then phase 1 is started again, phase 2 will appear started. The side effects seem minor though
> {quote}
> {quote}
> We have a long term goal to somehow verify every service can be stopped and started with the expected effect. Right now many of our services are not restartable which makes potential new features like partial deployment standby hard to achieve. So Im just offering pointers whenever I see lifecycle symmetry issues.
> {quote}



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)