[jboss-jira] [JBoss JIRA] (DROOLS-2815) [DMN Designer] Make Expression Type dependent on Diagram Node

[Michael Anstis (JIRA)]

    [ https://issues.jboss.org/browse/DROOLS-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621953#comment-13621953 ] 

Michael Anstis commented on DROOLS-2815:
----------------------------------------

[~jomarko] This JIRA actually highlights a different issue, than what we thought!

The Expression Editor (grid) for a {{BusinessKnowledgeModel}} is actually showing the expression for the BKM's _encapsulatedLogic_ instead of the _encapsulatedLogic_ itself (i.e. it's showing {{BKM.encapsulatedLogic.expression}} instead of {{BKM.encapsulatedLogic}}). The former is undefined (and hence we see the "select an expression type" drop-down) whereas the latter (and correct form) is a {{FunctionDefinition}} instance and hence the BKM grid should be pre-populated with a {{FunctionDefinition}}. The ability to not delete/clear the BKMs _encapsulatedLogic_ remains (and will be fixed for this JIRA).

Furthermore, as [~tirelli] states, it is technically possible for a {{Decision}}'s expression to be a {{FunctionDefinition}} and hence to "..restrict this *if and only if* it makes the implementation of the editor easier...". Since we'd need to *add* logic to remove {{FunctionDefinition}} from the {{Decision}} editor I conclude (a) it consequentially makes implementation more difficult, (b) we're removing specified functionality (all be it "..quite an edge case..."); so think we should leave {{FunctionDefinition}} available for {{Decision}} nodes.

So, in summary, the fix for this JIRA will add the following:-
# Show {{BusinessKnowledgeModel.encapsulatedLogic}} in the grid view.
# Prevent deletion/clearing of the {{BusinessKnowledgeModel.encapsulatedLogic}} when "top level" (i.e. not when nested in a {{ContextEntry}} etc)
# Continue to allow use of {{FunctionDefinition}} for {{Decision}} nodes.


> [DMN Designer] Make Expression Type dependent on Diagram Node
> -------------------------------------------------------------
>
>                 Key: DROOLS-2815
>                 URL: https://issues.jboss.org/browse/DROOLS-2815
>             Project: Drools
>          Issue Type: Feature Request
>          Components: DMN Editor
>    Affects Versions: 7.9.0.Final
>            Reporter: Jozef Marko
>            Assignee: Michael Anstis
>              Labels: drools-tools
>
> The expression editor options should be dependent on the diagram node type. 
> h2. Decision Node
> Should allow all expression types except of *Function*
> h2. BKM Node
> Should allow only *Function* expression type. 
> h3. Further improvement
> BKM node has automatically function expression inside - separate jira, or won't be implemented?
> ([~jomarko] IMO If/when [~tirelli] confirms the subject of this JIRA is the expected/required operation I'd ensure BKMs have a Function set and cannot be cleared).
> h2. Acceptance tests
> - Not possible to set *function expression type* for Decision node
> - Possible to set just *function expression type* for BKM node 
> -- Created automatically if we decide to implement here
> - Dialog shown if opened file from external tool that doesn't follow this restriction



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)