[jboss-jira] [JBoss JIRA] (DROOLS-2923) DMN implement EvalHelper cache eviction PR #1997

[Matteo Mortari (JIRA)]

     [ https://issues.jboss.org/browse/DROOLS-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matteo Mortari updated DROOLS-2923:
-----------------------------------
    Description: 
Submitted PR #1997 proposes a cache lookup for Method accessor for FEEL (EvalHelper#getGenericAccessor) but missing cache eviction make the optimization incompatible with KieContainer upgrade. This JIRA will provide report on optimization and cache eviction mechanism.

Before, baseline of reference:
 !screenshot-1.png|thumbnail! 
 !screenshot-2.png|thumbnail! 

After, with cache eviction as proposed by PR #1997
 !screenshot-3.png|thumbnail! 
 !screenshot-4.png|thumbnail! 

We can notice the EvalHelper method is no longer a "hot spot" and the 10K evaluations of the model takes less than the creation of the DMNRuntime hence is no longer the top expensive operation in the test.

  was:
Submitted PR #1997 proposes a cache lookup for Method accessor for FEEL (EvalHelper#getGenericAccessor) but missing cache eviction make the optimization incompatible with KieContainer upgrade. This JIRA will provide report on optimization and cache eviction mechanism.

Baseline:
 !screenshot-1.png|thumbnail! 
 !screenshot-2.png|thumbnail! 

With cache eviction as proposed by PR #1997
 !screenshot-3.png|thumbnail! 




> DMN implement EvalHelper cache eviction PR #1997
> ------------------------------------------------
>
>                 Key: DROOLS-2923
>                 URL: https://issues.jboss.org/browse/DROOLS-2923
>             Project: Drools
>          Issue Type: Task
>          Components: dmn engine
>            Reporter: Matteo Mortari
>            Assignee: Matteo Mortari
>         Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png, screenshot-4.png
>
>
> Submitted PR #1997 proposes a cache lookup for Method accessor for FEEL (EvalHelper#getGenericAccessor) but missing cache eviction make the optimization incompatible with KieContainer upgrade. This JIRA will provide report on optimization and cache eviction mechanism.
> Before, baseline of reference:
>  !screenshot-1.png|thumbnail! 
>  !screenshot-2.png|thumbnail! 
> After, with cache eviction as proposed by PR #1997
>  !screenshot-3.png|thumbnail! 
>  !screenshot-4.png|thumbnail! 
> We can notice the EvalHelper method is no longer a "hot spot" and the 10K evaluations of the model takes less than the creation of the DMNRuntime hence is no longer the top expensive operation in the test.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)