[jboss-jira] [JBoss JIRA] (WFLY-10808) Default Value of local-receiver-pass-by-value in jboss-ejb-client Descriptor is Not Respected

[Bartosz Baranowski (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-10808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13623698#comment-13623698 ] 

Bartosz Baranowski commented on WFLY-10808:
-------------------------------------------

Cause: https://issues.jboss.org/browse/AS7-3330

Tad cryptic change.


For some reason I cant create PR

{quote}
diff --git a/ee/src/main/java/org/jboss/as/ee/structure/EJBClientDescriptor10Parser.java b/ee/src/main/java/org/jboss/as/ee/structure/EJBClientDescriptor10Parser.java
index 84786e7abb..b0d3ab6fdd 100644
--- a/ee/src/main/java/org/jboss/as/ee/structure/EJBClientDescriptor10Parser.java
+++ b/ee/src/main/java/org/jboss/as/ee/structure/EJBClientDescriptor10Parser.java
@@ -129,7 +129,7 @@ class EJBClientDescriptor10Parser implements XMLElementReader<EJBClientDescripto
     protected void parseEJBReceivers(final XMLExtendedStreamReader reader, final EJBClientDescriptorMetaData ejbClientDescriptorMetaData) throws XMLStreamException {
 
         // initialize the local-receiver-pass-by-value to the default true
-        Boolean localReceiverPassByValue = null;
+        Boolean localReceiverPassByValue = true;
 
         final int count = reader.getAttributeCount();
         for (int i = 0; i < count; i++) {

{quote}

> Default Value of local-receiver-pass-by-value in jboss-ejb-client Descriptor is Not Respected
> ---------------------------------------------------------------------------------------------
>
>                 Key: WFLY-10808
>                 URL: https://issues.jboss.org/browse/WFLY-10808
>             Project: WildFly
>          Issue Type: Bug
>          Components: EE, EJB
>    Affects Versions: 11.0.0.Final, 12.0.0.Final, 13.0.0.Final
>            Reporter: Joshua Swett
>            Assignee: Bartosz Baranowski
>            Priority: Minor
>         Attachments: TestWAR.war
>
>
> The jboss-ejb-client.xml deployment descriptor file can be used to configure the pass semantics of the local EJB receiver using the local-receiver-pass-by-value attribute.
> As per the EJB spec, the default behaviour should be to pass by value, and this is appropriately reflected in the jboss-ejb-client XSD.  As of Wildfly 11, the *omission* of the local-receiver-pass-by-value attribute in a jboss-ejb-client deployment descriptor actually results in remote EJB parameters and the return value being passed by reference as opposed to the documented default of being passed by value.
> It appears that this bug is a result of changes made for WFLY-5403.  The root cause is that the EJBClientDescriptorMetaDataProcessor.java class only uses the pass-by-value receiver if the local-receiver-pass-by-value attribute is Boolean.TRUE (line 177 in 13.0.0.Final), but EJBClientDescriptor10Parser.java defaults the value to null if it is not included in the jboss-ejb-client.xml (line 132 in 13.0.0.Final).  The old and working behaviour was to fallback to the value configured at the ejb subsystem level if the jboss-ejb-client.xml excluded the attribute.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)