[jboss-jira] [JBoss JIRA] (WFLY-10784) WeldStartCompletionService failed when optional components not installed

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-10784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624600#comment-13624600 ] 

Brian Stansberry commented on WFLY-10784:
-----------------------------------------

[~manovotn] Ignore the deprecation. MSC has new API that it wanted people to use, so it deprecated the old one. But almost nothing in WildFly uses that new API, and it's not a no-thought activity to switch chunk of functionality to it; things can break when partial conversions are done. IMHO that deprecation was premature as it just scares people.

That said, I'm not sure you need to do DeploymentPhaseContext.getServiceRegistry().getService(WeldBootstrapService.SERVICE_NAME). Perhaps you could just retain WeldStartCompletionService and have it depend on / inject WeldBootstrapService.  But the stuff from L296-299 at https://github.com/wildfly/wildfly/pull/10795/files#diff-5437e2864026abc7549cfb4be4871565R296 isn't necessary.  In my last comment I didn't mean to imply WeldStartCompletionService shouldn't depend on anything; just that it didn't need to depend on the services that are causing this issue.

> WeldStartCompletionService failed when optional components not installed
> ------------------------------------------------------------------------
>
>                 Key: WFLY-10784
>                 URL: https://issues.jboss.org/browse/WFLY-10784
>             Project: WildFly
>          Issue Type: Bug
>          Components: CDI / Weld
>    Affects Versions: 12.0.0.Final, 13.0.0.Final
>            Reporter: Alexander Kudrevatykh
>            Assignee: Matej Novotny
>         Attachments: arq-test.tar.xz
>
>
> WebComponents are optional and fail in initialising it not causes fail of deployment, but when starting EAR application with included WAR fail in deployment since Wildfly 12 because WeldStartCompletionService depends on all components regardless of their type



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)