[jboss-jira] [JBoss JIRA] (WFLY-10864) MP Health reports UP when there is port collision for port 8080

[Lin Gao (Jira)]

    [ https://issues.jboss.org/browse/WFLY-10864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13673491#comment-13673491 ] 

Lin Gao commented on WFLY-10864:
--------------------------------

I have a commit at: https://github.com/gaol/wildfly/commit/dbdd32a98aa0c34a771d96cb5db9c7fa911d27fd

But it will break [microprofile-tck|https://github.com/eclipse/microprofile-health/blob/1.0/tck/src/main/java/org/eclipse/microprofile/health/tck/SingleProcedureSuccessfulTest.java#L68].

I think I need to put this issue on hold before the [system support for health check specification|https://github.com/eclipse/microprofile-health/issues/37] is finalized.

> MP Health reports UP when there is port collision for port 8080
> ---------------------------------------------------------------
>
>                 Key: WFLY-10864
>                 URL: https://issues.jboss.org/browse/WFLY-10864
>             Project: WildFly
>          Issue Type: Bug
>          Components: MP Health
>            Reporter: Rostislav Svoboda
>            Assignee: Lin Gao
>            Priority: Critical
>
> MP Health reports UP when there is port collision for port 8080.
> I have simple python app to acquire port 8080 and once it runs I start WF server
> {code}
> import SimpleHTTPServer
> import SocketServer
> PORT = 8080
> Handler = SimpleHTTPServer.SimpleHTTPRequestHandler
> httpd = SocketServer.TCPServer(("127.0.0.1", PORT), Handler)
> print "serving at port", PORT
> httpd.serve_forever()
> {code}
> WF reports Address already in use /127.0.0.1:8080, deployments are not deployed.
> Accessing http://localhost:9990/health/ reports "outcome":"UP"
> I think this is wrong and DOWN should be reported.
> Spec is misleading because it says {{A producer without health check procedures installed MUST returns positive overall outcome (i.e. HTTP 200)}} but it silently assumes server started correctly.
> I believe authors of the spec expected that if there is some trouble like port collision the server doesn't start, WildFly is a bit further as it allows to boot even if some services are not started properly.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)