[jboss-jira] [JBoss JIRA] (WFLY-11458) Timed - difference between Prometheus and JSON format

[Bartosz Baranowski (Jira)]

    [ https://issues.jboss.org/browse/WFLY-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674178#comment-13674178 ] 

Bartosz Baranowski commented on WFLY-11458:
-------------------------------------------

Difference comes from : https://github.com/smallrye/smallrye-metrics/blob/master/implementation/src/main/java/io/smallrye/metrics/exporters/PrometheusUnit.java#L91


{quote}
PrometheusUnit.scaleToBase(String, Double) line: 144	
PrometheusExporter.writeValueLine(StringBuffer, MetricRegistry$Type, String, double, Metadata, Tag, boolean) line: 273	
PrometheusExporter.writeValueLine(StringBuffer, MetricRegistry$Type, String, double, Metadata, Tag) line: 246	
PrometheusExporter.writeValueLine(StringBuffer, MetricRegistry$Type, String, double, Metadata) line: 242	
PrometheusExporter.writeTypeAndValue(StringBuffer, MetricRegistry$Type, String, double, String, Metadata) line: 238	
PrometheusExporter.writeMeterRateValues(StringBuffer, MetricRegistry$Type, Metered, Metadata) line: 232	
PrometheusExporter.writeTimerValues(StringBuffer, MetricRegistry$Type, TimerImpl, Metadata) line: 177	
PrometheusExporter.exposeEntries(Type, StringBuffer, MetricRegistry, Map<String,Metric>) line: 154	
PrometheusExporter.exportOneMetric(MetricRegistry$Type, String) line: 105	
MetricsRequestHandler.handleRequest(String, String, Stream<String>, Responder) line: 100	
MetricsContextService$1.handleRequest(HttpServerExchange) line: 93	
ServerErrorReadinessHandler(RealmReadinessHandler).handleRequest(HttpServerExchange) line: 51	
ServerErrorReadinessHandler.handleRequest(HttpServerExchange) line: 35	
PathHandler.handleRequest(HttpServerExchange) line: 94	
ChannelUpgradeHandler.handleRequest(HttpServerExchange) line: 211	
CacheHandler.handleRequest(HttpServerExchange) line: 92	
SimpleErrorPageHandler.handleRequest(HttpServerExchange) line: 78	
CanonicalPathHandler.handleRequest(HttpServerExchange) line: 49	
ManagementHttpRequestHandler.handleRequest(HttpServerExchange) line: 57	
CorsHttpHandler.handleRequest(HttpServerExchange) line: 75	
ManagementHttpServer$UpgradeFixHandler.handleRequest(HttpServerExchange) line: 662	
Connectors.executeRootHandler(HttpHandler, HttpServerExchange) line: 360	
HttpReadListener.handleEventWithNoRunningRequest(ConduitStreamSourceChannel) line: 255	
HttpReadListener.handleEvent(ConduitStreamSourceChannel) line: 136	
HttpOpenListener.handleEvent(StreamConnection, PooledByteBuffer) line: 162	
HttpOpenListener.handleEvent(StreamConnection) line: 100	
HttpOpenListener.handleEvent(Channel) line: 57	
ChannelListeners.invokeChannelListener(T, ChannelListener<? super T>) line: 92	
ChannelListeners$10.handleEvent(AcceptingChannel<C>) line: 291	
ChannelListeners$10.handleEvent(Channel) line: 286	
ChannelListeners.invokeChannelListener(T, ChannelListener<? super T>) line: 92	
QueuedNioTcpServer$1.run() line: 131	
WorkerThread.safeRun(Runnable) line: 612	
WorkerThread.run() line: 479	

{quote}

Im trying to fiure out the rationale behind this. JsonExporter writes just raw value( as does OpenLiberty for every call): https://github.com/smallrye/smallrye-metrics/blob/master/implementation/src/main/java/io/smallrye/metrics/exporters/JsonExporter.java#L139

> Timed - difference between Prometheus and JSON format
> -----------------------------------------------------
>
>                 Key: WFLY-11458
>                 URL: https://issues.jboss.org/browse/WFLY-11458
>             Project: WildFly
>          Issue Type: Bug
>          Components: MP Metrics
>    Affects Versions: 15.0.0.Final
>            Reporter: Rostislav Svoboda
>            Assignee: Bartosz Baranowski
>            Priority: Critical
>
> There are differences in reported results between Prometheus and JSON format.
> When using the same deployment with OpenLiberty there are no differences in reported results between Prometheus and JSON format.
> https://github.com/smallrye/smallrye-metrics/issues/40



--
This message was sent by Atlassian Jira
(v7.12.1#712002)