[jboss-jira] [JBoss JIRA] (WFLY-11471) Add expressions to enable statistics

[Frank Langelage (Jira)]

    [ https://issues.jboss.org/browse/WFLY-11471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675523#comment-13675523 ] 

Frank Langelage commented on WFLY-11471:
----------------------------------------

At least according to the schemas ejb3, infinispan and the webservices module have statistics:

*+ejb3+*
            <statistics enabled="${wildfly.ejb3.statistics-enabled:${wildfly.statistics-enabled:false}}"/>

*+infinispan+*
<             <cache-container name="server" default-cache="default" module="org.wildfly.clustering.server" statistics-enabled="${wildfly.infinispan.statistics-enabled:${wildfly.statistics-enabled:false}}">
<                 <local-cache name="default" statistics-enabled="${wildfly.infinispan.statistics-enabled:${wildfly.statistics-enabled:false}}">
---
>             <cache-container name="server" default-cache="default" module="org.wildfly.clustering.server">
>                 <local-cache name="default">

<             <cache-container name="web" default-cache="passivation" module="org.wildfly.clustering.web.infinispan" statistics-enabled="${wildfly.infinispan.statistics-enabled:${wildfly.statistics-enabled:false}}">
<                 <local-cache name="passivation" statistics-enabled="${wildfly.infinispan.statistics-enabled:${wildfly.statistics-enabled:false}}">
---
>             <cache-container name="web" default-cache="passivation" module="org.wildfly.clustering.web.infinispan">
>                 <local-cache name="passivation">

<             <cache-container name="ejb" aliases="sfsb" default-cache="passivation" module="org.wildfly.clustering.ejb.infinispan" statistics-enabled="${wildfly.infinispan.statistics-enabled:${wildfly.statistics-enabled:false}}">
<                 <local-cache name="passivation" statistics-enabled="${wildfly.infinispan.statistics-enabled:${wildfly.statistics-enabled:false}}">
---
>             <cache-container name="ejb" aliases="sfsb" default-cache="passivation" module="org.wildfly.clustering.ejb.infinispan">
>                 <local-cache name="passivation">

<             <cache-container name="hibernate" module="org.infinispan.hibernate-cache" statistics-enabled="${wildfly.infinispan.statistics-enabled:${wildfly.statistics-enabled:false}}">
<                 <local-cache name="entity" statistics-enabled="${wildfly.infinispan.statistics-enabled:${wildfly.statistics-enabled:false}}">
---
>             <cache-container name="hibernate" module="org.infinispan.hibernate-cache">
>                 <local-cache name="entity">

<                 <local-cache name="local-query" statistics-enabled="${wildfly.infinispan.statistics-enabled:${wildfly.statistics-enabled:false}}">
---
>                 <local-cache name="local-query">

<                 <local-cache name="timestamps" statistics-enabled="${wildfly.infinispan.statistics-enabled:${wildfly.statistics-enabled:false}}"/>
---
>                 <local-cache name="timestamps"/>

*+webservices+*
<         <subsystem xmlns="urn:jboss:domain:webservices:2.0" statistics-enabled="${wildfly.webservices.statistics-enabled:${wildfly.statistics-enabled:false}}">
---
>         <subsystem xmlns="urn:jboss:domain:webservices:2.0">


> Add expressions to enable statistics
> ------------------------------------
>
>                 Key: WFLY-11471
>                 URL: https://issues.jboss.org/browse/WFLY-11471
>             Project: WildFly
>          Issue Type: Enhancement
>          Components: JCA, JMS, MP Metrics, Transactions, Web (Undertow)
>    Affects Versions: 15.0.0.Final
>            Reporter: Jeff Mesnil
>            Assignee: Jeff Mesnil
>            Priority: Major
>             Fix For: 16.0.0.Beta1
>
>
> With the microprofile-metrics-smallrye extension, we can expose WildFly metrics to monitoring tools such as Promotheus.
> However, some of these metrics can have performance/memory impact and are not computed by default. They are control by attributes named `statistics-enabled` on the WildFly resources those runtime provides these metrics.
> If an user wants to collect such metrics, he has to set these `statistics-enabled` attributes to `true` for all resources.
> In order to improve user experience, our shipped standalone configuration could use expressions so that the user would have to set a single system property to enable these metrics.
> The format would be:
> {code}
> statistics-enabled=${wildfly.statistics-enabled:${wildfly.<xxx>.statistics-enabled:false}}
> {code}
> where <xxx> are names of the resources that exposes the metrics: undertow, transactions, datasources, messaging-activemq
> The nested expressions allows to have a global system property to enable *all* statistics: (wildfly.statistics-enabled) and specific system properties to enable/disable only some metrics (e.g. wildfly.transactions.statistics-enabled).
> Use case:
> * start the standalone profile as usual
>   * ./bin/standalone.sh
>   * => all statistics-enabled attributes are resolved to false
> * start the standalone profile with all statistics:
>   * ./bin/standalone.sh -Dwildfly.statistics-enabled=true
>   * => all statistics-enabled attributes are resolved to true
> * start the standalone profile with only undertow statistics:
>   * ./bin/standalone.sh -Dwildfly.undertow.statistics-enabled=true
>   * => all statistics-enabled attributes are resolved to true
> * start the standalone profile with only undertow statistics:
>   * ./bin/standalone.sh -Dwildfly.undertow.statistics-enabled=true
>   * => only undertow statistics are enabled
> * start the standalone profile with all but undertow statistics:
>   * ./bin/standalone.sh -Dwildfly.undertow.statistics-enabled=false -Dwildfly.statistics-enabled=true
>   * => All but undertow statistics are enabled



--
This message was sent by Atlassian Jira
(v7.12.1#712002)