[jboss-jira] [JBoss JIRA] (DROOLS-2308) Investigate FieldActionInspector hasValue implementation

[Jozef Marko (JIRA)]

Jozef Marko created DROOLS-2308:
-----------------------------------

             Summary: Investigate FieldActionInspector hasValue implementation
                 Key: DROOLS-2308
                 URL: https://issues.jboss.org/browse/DROOLS-2308
             Project: Drools
          Issue Type: Task
          Components: Guided Decision Table Editor
    Affects Versions: 6.5.0.Final
            Reporter: Jozef Marko
            Assignee: Toni Rikkola


The current implementation of {{[FieldActionInspector#hasValue|https://github.com/kiegroup/drools-wb/blob/6.5.x/drools-wb-screens/drools-wb-guided-dtable-editor/drools-wb-guided-dtable-editor-client/src/main/java/org/drools/workbench/screens/guided/dtable/client/widget/analysis/action/FieldActionInspector.java]}} is like:


{code:java}
        switch (value.getDataType()) {
            case NUMERIC:
            case NUMERIC_BIGDECIMAL:
            case NUMERIC_BIGINTEGER:
            case NUMERIC_BYTE:
            case NUMERIC_DOUBLE:
            case NUMERIC_FLOAT:
            case NUMERIC_INTEGER:
            case NUMERIC_LONG:
            case NUMERIC_SHORT:
                return value.getNumericValue() != null;
            case BOOLEAN:
                return value.getBooleanValue() != null;
            default:
                return value.getStringValue() != null && !value.getStringValue().isEmpty();
        }
{code}

Please investigate, if the switch above shouldn't handle also Date data type.




--
This message was sent by Atlassian JIRA
(v7.5.0#75005)