[jboss-jira] [JBoss JIRA] (WFLY-5459) Rename JGroups-related attributes

[Paul Ferraro (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-5459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533229#comment-13533229 ] 

Paul Ferraro commented on WFLY-5459:
------------------------------------

As part of WFLY-9746, I introduced a new attribute, so it made sense to address this issue at the same time.  We now have:

jgroups-stack (deprecated) - references a protocol stack
jgroups-channel - references a jgroups channel
jgroups-cluster - identifies the group with/from which to broadcast/discover nodes

> Rename JGroups-related attributes
> ---------------------------------
>
>                 Key: WFLY-5459
>                 URL: https://issues.jboss.org/browse/WFLY-5459
>             Project: WildFly
>          Issue Type: Bug
>          Components: JMS
>    Affects Versions: 10.0.0.CR2
>            Reporter: Jeff Mesnil
>            Assignee: Paul Ferraro
>
> Based on Paul feedback in https://github.com/wildfly/wildfly/pull/8221#issuecomment-145013596:
> {quote}You may want to consider renaming these attributes, however, since the names are now a little confusing. For example, jgroups-stack is perhaps better described as jgroups-channel-factory, since it can specify either a stack name or a channel name. jgroups-channel is also confusing in this context, since this specifies either the cluster name, in the case where jgroups-stack specifies a stack; or the fork name, in the case where the jgroups-stack specifies a channel name. Perhaps jgroups-cluster-name is a better choice?{quote}



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)