[jboss-jira] [JBoss JIRA] (DROOLS-2341) Asset validation show errors of other assets

Michael Anstis (JIRA) issues at jboss.org
Wed Feb 21 08:55:00 EST 2018


    [ https://issues.jboss.org/browse/DROOLS-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536386#comment-13536386 ] 

Michael Anstis commented on DROOLS-2341:
----------------------------------------

[~jomarko] OK, so https://github.com/kiegroup/kie-wb-common/pull/1443 fixes the cause of validation errors including those for other assets. However there is another issue now that {{ValidatorBuildService.getDestinationPath()}} returns {{/src/main/resources}} when running the webapp's but {{src/main/resources}} when running the tests in {{kie-wb-common}}. This code was changed for the Repository == Project changes... ATM IDK whether it's the tests at fault, the workbench or the changes for Repository == Project.. Investigating a bit more.

> Asset validation show errors of other assets
> --------------------------------------------
>
>                 Key: DROOLS-2341
>                 URL: https://issues.jboss.org/browse/DROOLS-2341
>             Project: Drools
>          Issue Type: Bug
>          Components: Guided Decision Table Editor, Guided Rule Editor, Guided Template Editor
>    Affects Versions: 7.7.0.Final
>            Reporter: Jozef Marko
>            Assignee: Michael Anstis
>            Priority: Blocker
>
> Setting this as blocker as the amount of failing tests. 
> The issue can be seen if the project contains two assets, for example:
> - a.rdrl - valid
> - b.drl - invalid
> Then if user validates the asset *a*, he will see errors of the asset *b*
> The issue was revealed by the tests:
> * org.drools.workbench.screens.drltext.backend.server.DRLTextEditorServiceImplCDITest.testValidDSRLFile
> *  org.drools.workbench.screens.drltext.backend.server.DRLTextEditorServiceImplCDITest.testInvalidDSRLFile
> * org.drools.workbench.screens.drltext.backend.server.DRLTextEditorServiceImplCDITest.testDSLCompinedWithPureDRL
> * org.drools.workbench.screens.drltext.backend.server.DRLTextEditorServiceImplCDITest.testDRLFileWithGlobalVariable
> * org.drools.workbench.screens.drltext.backend.server.DRLTextEditorServiceImplCDITest.testDRLFileWithExplicitNonExistingImport
> * org.drools.workbench.screens.drltext.backend.server.DRLTextEditorServiceImplCDITest.testDRLFileWithExplicitImport
> * org.drools.workbench.screens.drltext.backend.server.DRLTextEditorServiceImplCDITest.testValidDRLFileWithTwoRules
> * org.drools.workbench.screens.drltext.backend.server.DRLTextEditorServiceImplCDITest.testValidDRLFile
> * org.drools.workbench.screens.drltext.backend.server.DRLTextEditorServiceImplCDITest.testDRLFileWithUnknownGlobalVariable
> * org.drools.workbench.screens.drltext.backend.server.DRLTextEditorServiceImplCDITest.testDRLFileWrongConstructor
> * org.drools.workbench.screens.guided.dtable.backend.server.GuidedDecisionTableEditorServiceImplCDITest.testFunctionFromDrl
> * org.drools.workbench.screens.guided.rule.backend.server.GuidedRuleEditorServiceImplCDITest.testAbbreviatedCondition
> * org.drools.workbench.screens.guided.rule.backend.server.GuidedRuleEditorServiceImplCDITest.testValidateRuleThatInherit
> The tests was temporarily ignored by: [PR|https://github.com/kiegroup/drools-wb/pull/814]



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)


More information about the jboss-jira mailing list