[jboss-jira] [JBoss JIRA] (WFLY-9908) Unused PathAddress variable in BroadcastGroupAdd.performRuntime method

Radoslav Husar (JIRA) issues at jboss.org
Wed Feb 28 04:24:00 EST 2018


     [ https://issues.jboss.org/browse/WFLY-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Radoslav Husar updated WFLY-9908:
---------------------------------
    Priority: Trivial  (was: Minor)


> Unused PathAddress variable in BroadcastGroupAdd.performRuntime method
> ----------------------------------------------------------------------
>
>                 Key: WFLY-9908
>                 URL: https://issues.jboss.org/browse/WFLY-9908
>             Project: WildFly
>          Issue Type: Bug
>          Components: Clustering, JMS
>    Affects Versions: 12.0.0.Beta1
>            Reporter: Martin Styk
>            Assignee: Radoslav Husar
>            Priority: Trivial
>
> Variable {{final PathAddress address}} in method {{BroadcastGroupAdd.performRuntime}} is declared but never used.
> {code}
>     @Override
>     protected void performRuntime(OperationContext context, ModelNode operation, ModelNode model) throws OperationFailedException {
>         ...
>         else {
>             final PathAddress address = context.getCurrentAddress();
>             final String name = context.getCurrentAddressValue();
>             final ServiceTarget target = context.getServiceTarget();
>             if (model.hasDefined(JGROUPS_CLUSTER.getName())) {
>                 // nothing to do, in that case, the clustering.jgroups subsystem will have setup the stack
>             } else if(model.hasDefined(RemoteTransportDefinition.SOCKET_BINDING.getName())) {
>                 final GroupBindingService bindingService = new GroupBindingService();
>                 target.addService(GroupBindingService.getBroadcastBaseServiceName(serviceName).append(name), bindingService)
>                         .addDependency(SocketBinding.JBOSS_BINDING_NAME.append(model.get(SOCKET_BINDING).asString()), SocketBinding.class, bindingService.getBindingRef())
>                         .install();
>             }
>         }
> } 
> {code}
> https://github.com/wildfly/wildfly/blame/master/messaging-activemq/src/main/java/org/wildfly/extension/messaging/activemq/BroadcastGroupAdd.java#L129



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)


More information about the jboss-jira mailing list