[jboss-jira] [JBoss JIRA] (ELY-1483) japicmp detects compatibility issues

[Martin Choma (JIRA)]

    [ https://issues.jboss.org/browse/ELY-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510748#comment-13510748 ] 

Martin Choma commented on ELY-1483:
-----------------------------------

Packages asn1 and x500 were included into check per Farah comment https://github.com/wildfly-security/wildfly-elytron/pull/1038#discussion_r158077176

But thinking about it now, probably they should be not included in this stage, because they were private in 1.1.7.Final (weren't mentioned in module definition)?

They should be included once we will compare 1.2.x with 1.next

> japicmp detects compatibility issues
> ------------------------------------
>
>                 Key: ELY-1483
>                 URL: https://issues.jboss.org/browse/ELY-1483
>             Project: WildFly Elytron
>          Issue Type: Bug
>          Components: API / SPI
>    Affects Versions: 1.2.0.Beta11
>            Reporter: Martin Choma
>            Priority: Critical
>             Fix For: 1.2.0.Beta12
>
>         Attachments: japicmp.html
>
>
> I have used japicmp tool to compare public API [1]. Version 1.1.7.Final was compared with master HEAD (in time of writing 1.2.0.Beta12-SNAPSHOT).  These incompatibilities were detected:
> - removed org.wildfly.security.asn1.ASN1 (moved to org.wildfly.security.asn1.util)
> - removed org.wildfly.security.asn1.OidsUtil (moved to org.wildfly.security.asn1.util)
> - removed org.wildfly.security.asn1.OidsUtil$Category (moved to org.wildfly.security.asn1.util)
> - removed org.wildfly.security.x500.X500PrincipalUtil (moved to org.wildfly.security.x500.util)
> - removed org.wildfly.security.asn1.ASN1Encoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
> - removed org.wildfly.security.asn1.ASN1Encoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
> - constructor less accessible package_protected  (<-  public ) org.wildfly.security.asn1.DERDecoder.DERDecoder(org.wildfly.security.util.ByteIterator)
> - constructor less accessible package_protected  (<-  public ) org.wildfly.security.asn1.DEREncoder.DEREncoder(org.wildfly.security.util.ByteIterator)  
> - method less accessible package_protected  (<-  public ) org.wildfly.security.asn1.DEREncoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
> - method less accessible package_protected  (<-  public ) org.wildfly.security.asn1.DEREncoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
> [1] https://github.com/wildfly-security/wildfly-elytron/pull/1067



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)