[jboss-jira] [JBoss JIRA] (WFCORE-3550) Inefficient algorithm for converting JMX attribute names to native resource attribute names

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-3550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13524109#comment-13524109 ] 

Brian Stansberry commented on WFCORE-3550:
------------------------------------------

Note: looking more closely revealed that the DMR description was additionally used later. But the way the necessary description is obtained can be more efficient, which the PR for this does. WFCORE-3551 is about finding a way to further reduce or maybe eliminate the need for DMR descriptions.

> Inefficient algorithm for converting JMX attribute names to native resource attribute names
> -------------------------------------------------------------------------------------------
>
>                 Key: WFCORE-3550
>                 URL: https://issues.jboss.org/browse/WFCORE-3550
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: JMX
>            Reporter: Brian Stansberry
>            Assignee: Brian Stansberry
>
> ModelControllerMBeanHelper is taking an MRR, using it to create a DMR ModelNode description of the resource type, and then iterating over the attribute names in that description tree to try and match up with the requested JMX attribute name. That middle step of creating the DMR description is very expensive; it produces a very large node tree. It's not necessary; the MRR already can tell you the legal attribute names.
> I believe this is legacy cruft from the early AS 7 days when the MRR wasn't always reliable for all attribute names. But it's been reliable for a long time now.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)