[jboss-jira] [JBoss JIRA] (DROOLS-2662) Guided Rule Editor does not open popup when binding a variable of type java.time.LocalDate in another constraint

[Jozef Marko (JIRA)]

    [ https://issues.jboss.org/browse/DROOLS-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13603052#comment-13603052 ] 

Jozef Marko edited comment on DROOLS-2662 at 7/10/18 9:47 AM:
--------------------------------------------------------------

Just for record, the reason why issue occurs just for {{java.time.LocalDate}} field is that {{AsyncPackageDataModelOracleImpl}} assumes {{java.time.LocalDate}} fields have type {{Comparable}} while {{java.util.Date}} fields have type {{Date}}.

This difference caused that different branches of code were executed for different field types and we didn't spot the issue sooner.

If we decide to support {{java.time.LocalDate}} we will have to update [converter|https://github.com/kiegroup/kie-wb-common/blob/master/kie-wb-common-services/kie-wb-common-datamodel/kie-wb-common-datamodel-backend/src/main/java/org/kie/workbench/common/services/datamodel/backend/server/builder/projects/JavaTypeSystemTranslator.java]


was (Author: jomarko):
Just for record, the reason why issue occurs just for {java.time.LocalDate} field is that {AsyncPackageDataModelOracleImpl} assumes {java.time.LocalDate} fields have type {Comparable} while {java.util.Date} fields have type {Date}.

This difference caused that different branches of code were executed for different field types and we didn't spot the issue sooner.

If we decide to support {java.time.LocalDate} we will have to update [converter|https://github.com/kiegroup/kie-wb-common/blob/master/kie-wb-common-services/kie-wb-common-datamodel/kie-wb-common-datamodel-backend/src/main/java/org/kie/workbench/common/services/datamodel/backend/server/builder/projects/JavaTypeSystemTranslator.java]

> Guided Rule Editor does not open popup when binding a variable of type java.time.LocalDate in another constraint
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: DROOLS-2662
>                 URL: https://issues.jboss.org/browse/DROOLS-2662
>             Project: Drools
>          Issue Type: Bug
>          Components: Guided Rule Editor
>            Reporter: Jozef Marko
>            Assignee: Jozef Marko
>         Attachments: out-15.ogv
>
>
> Consider a Data Object Test with a single field date of type java.time.LocalDate. When  using Guided Rule Editor with two different conditions on Test object, with two Test object (the condition are in two separated objects), when we bind the date to a variable the constraint pop up won't open for the other condition, showing an error in console.
> The attached video will clarify the issue.
> That does not seem to happen with built in types and not even with java.util.Date type.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)