[jboss-jira] [JBoss JIRA] (DROOLS-2049) Remove private void checkMarshallingUsingDsl method

[Jozef Marko (JIRA)]

     [ https://issues.jboss.org/browse/DROOLS-2049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jozef Marko updated DROOLS-2049:
--------------------------------
    Labels: drools-tools  (was: )


> Remove private void checkMarshallingUsingDsl method
> ---------------------------------------------------
>
>                 Key: DROOLS-2049
>                 URL: https://issues.jboss.org/browse/DROOLS-2049
>             Project: Drools
>          Issue Type: Task
>          Components: DSLs Editor
>    Affects Versions: 7.3.0.Final
>            Reporter: Jozef Marko
>            Assignee: Jozef Marko
>              Labels: drools-tools
>
> The [testclass|https://github.com/kiegroup/drools/blob/master/drools-workbench-models/drools-workbench-models-commons/src/test/java/org/drools/workbench/models/commons/backend/rule/RuleModelDRLPersistenceTest.java] contains methods shown bellow. There is potential error in tests that expect checkMarshallingUsingDsl will behave differently from checkMarshalling. This checkMarshallingUsingDsl should be removed and tests which use it should be rewritten.
> {code:java}
> private void checkMarshalling(String expected,
>                                   RuleModel m) {
>         String drl = ruleModelPersistence.marshal(m);
>         assertNotNull(drl);
>         if (expected != null) {
>             assertEqualsIgnoreWhitespace(expected,
>                                          drl);
>         }
>     }
>     private void checkMarshallingUsingDsl(String expected,
>                                           RuleModel m) {
>         String drl = ruleModelPersistence.marshal(m);
>         assertNotNull(drl);
>         if (expected != null) {
>             assertEqualsIgnoreWhitespace(expected,
>                                          drl);
>         }
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)