[jboss-jira] [JBoss JIRA] (DROOLS-2729) KieScanner tries to read test dependencies

Ales Dolecek (JIRA) issues at jboss.org
Thu Jul 12 03:06:00 EDT 2018


    [ https://issues.jboss.org/browse/DROOLS-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604101#comment-13604101 ] 

Ales Dolecek commented on DROOLS-2729:
--------------------------------------

And BTW: Passing filter to ArtifactResolver#getAllDependencies will also SIGNIFICANTLY reduce number of dependency descriptors needed to obtain from repository since any immediate non-compile dependencies are ignored right away so their dependencies are not considered (POMs downloaded) at all.

> KieScanner tries to read test dependencies
> ------------------------------------------
>
>                 Key: DROOLS-2729
>                 URL: https://issues.jboss.org/browse/DROOLS-2729
>             Project: Drools
>          Issue Type: Bug
>          Components: core engine
>    Affects Versions: 7.8.0.Final
>            Reporter: Ales Dolecek
>            Assignee: Mario Fusco
>
> Method KieRepositoryScannerImpl#indexArtifacts first reads ALL dependencies and then tries to exclude those with scope test/provided/system. This is wrong since the nested dependencies might have different scope. Conseder this case:
> A -> depends on B (with scope test)
> B -> depends on C (with scope compile)
> Asking for allDependencies will yield following descriptors:
> A (compile scope)
> B (test scope)
> C (compile scope)
> B gets discarded, but C remains and scanner will try to resolve it and add to class loader.
> Instead of fitering the results of ArtifactResolver#getAllDependencies() (without parameters) you should use overloaded version of this method that accepts dependency filter.
> I do not create rules via GUI, but have them in separate Maven project. This projects contains tests cases that check if the rules are OK. The tests create the knowlege base from filesystem and require drools-decisiontables in order to execute. 



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)


More information about the jboss-jira mailing list