[jboss-jira] [JBoss JIRA] (ELY-1239) Elytron client, elytron-1_0.xsd, protection-parameter-credentials is incorrectly defined as client-credentials-type.

[Justin Cook (JIRA)]

    [ https://issues.jboss.org/browse/ELY-1239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604708#comment-13604708 ] 

Justin Cook commented on ELY-1239:
----------------------------------

According to the discussion at https://github.com/wildfly-security/wildfly-elytron/pull/885, protection-parameter-credentials should remain as client-credentials-type due to a credential store being able to use any credential type as the protection parameter. [~dlofthouse] I recommend this issue be closed.

> Elytron client, elytron-1_0.xsd, protection-parameter-credentials is incorrectly defined as client-credentials-type.
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: ELY-1239
>                 URL: https://issues.jboss.org/browse/ELY-1239
>             Project: WildFly Elytron
>          Issue Type: Bug
>          Components: Authentication Client, Credential Store
>            Reporter: Hynek Švábek
>            Assignee: Justin Cook
>            Priority: Blocker
>             Fix For: 1.4.1.CR1
>
>
> Elytron client, elytron-1_0.xsd, *protection-parameter-credentials* is incorrectly defined as client-credentials-type [1].
> For *protection-parameter-credentials*  is valid only credential-store-reference element:
> {code}
>  <xsd:element name="credential-store-reference" type="credential-store-reference-type"/>
> {code}
> But now is *protection-parameter-credentials* defined as type *client-credentials-type* [1] which can have these values:
> {code}
>    <xsd:complexType name="client-credentials-type">
>         <xsd:choice minOccurs="0" maxOccurs="unbounded">
>             <xsd:element name="key-store-reference" type="key-store-ref-type"/>
>             <xsd:element name="credential-store-reference" type="credential-store-reference-type"/>
>             <xsd:element name="clear-password" type="clear-password-type"/>
>             <xsd:element name="hashed-password" type="hashed-password-type"/>
>             <xsd:element name="crypt-password" type="crypt-password-type"/>
>             <xsd:element name="key-pair" type="key-pair-type"/>
>             <xsd:element name="certificate" type="certificate-type"/>
>             <xsd:element name="public-key-pem" type="xsd:string"/>
>             <xsd:element name="bearer-token" type="bearer-token-type"/>
>             <xsd:element name="oauth2-bearer-token" type="oauth2-bearer-token-type"/>
>         </xsd:choice>
>     </xsd:complexType>
> {code}
> Please keep on mind that changes must be done accordingly in ElytronXMLParser too.
> [1] https://github.com/wildfly-security/wildfly-elytron/blob/1.1.0.Beta47/src/main/resources/schema/elytron-1_0.xsd#L100



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)