[jboss-jira] [JBoss JIRA] (WFWIP-57) MalformedInputException is thrown in case config-source dir contains binaries

[Rostislav Svoboda (JIRA)]

    [ https://issues.jboss.org/browse/WFWIP-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608001#comment-13608001 ] 

Rostislav Svoboda commented on WFWIP-57:
----------------------------------------

File size should be also checked, I can imagine 100kB would be more than enough size limit.

In my experiment text file 100kB == 1300 lines.

> MalformedInputException is thrown in case config-source dir contains binaries
> -----------------------------------------------------------------------------
>
>                 Key: WFWIP-57
>                 URL: https://issues.jboss.org/browse/WFWIP-57
>             Project: WildFly WIP
>          Issue Type: Bug
>          Components: MP Config
>         Environment: {noformat}
> git at github.com:jmesnil/wildfly.git:WFLY-10522_microprofile-config-smallrye_extension
> {noformat}
>            Reporter: Petr Kremensky
>            Assignee: Jeff Mesnil
>
> Management operation for adding a config-source dir fails with MalformedInputException in case that the dir contains some binaries.
> *reproduce*
> {noformat}
> TEST_DIR=/tmp/test_dir
> mkdir -p $TEST_DIR
> head -c 1K </dev/urandom > ${TEST_DIR}/random.data
> echo 'value' > ${TEST_DIR}/my.property
> sh wildfly-14.0.0.Beta1-SNAPSHOT/bin/standalone.sh &
> sh wildfly-14.0.0.Beta1-SNAPSHOT/bin/jboss-cli.sh -c "/subsystem=microprofile-config-smallrye/config-source=config:add(dir=${TEST_DIR})"
> {noformat}
> *expected*
> Binaries and e.g. corrupted files (log?) are ignored. 
> *actual*
> {noformat}
> 12:53:59,083 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 1) WFLYCTL0013: Operation ("add") failed - address: ([
>     ("subsystem" => "microprofile-config-smallrye"),
>     ("config-source" => "asd")
> ]): java.io.UncheckedIOException: java.nio.charset.MalformedInputException: Input length = 1
> 	at java.io.BufferedReader$1.hasNext(BufferedReader.java:574)
> 	at java.util.Iterator.forEachRemaining(Iterator.java:115)
> 	at java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
> 	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> 	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
> 	at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
> 	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> 	at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)
> 	at io.smallrye.config.DirConfigSource.readContent(DirConfigSource.java:72)
> 	at io.smallrye.config.DirConfigSource.scan(DirConfigSource.java:60)
> 	at io.smallrye.config.DirConfigSource.<init>(DirConfigSource.java:46)
> 	at org.wildfly.extension.microprofile.config.smallrye.ConfigSourceDefinition$1.performRuntime(ConfigSourceDefinition.java:120)
> ...
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)