[jboss-jira] [JBoss JIRA] (WFLY-10520) Add Hibernate ORM 5.3 compatibility transformer

[Scott Marlow (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608166#comment-13608166 ] 

Scott Marlow commented on WFLY-10520:
-------------------------------------

Is it worth moving the transformer into its own module?  Once an application adds a dependency on that module, the application will not work with the future releases that no longer contain that module.

Some choices are:
# Leave the transformer in the JPA subsystem and document that the only way to use it, is via the -DHibernate51CompatibilityTransformer=true system property option.
# Move the transformer into its own (Hibernate orm 5.1 native app transformer) module that applications can add a dependency on, but those applications will break when we remove that module in the future, so it might be better to only support the system property option.

Also, do we need an EAP7 jira for this issue?

> Add Hibernate ORM 5.3 compatibility transformer
> -----------------------------------------------
>
>                 Key: WFLY-10520
>                 URL: https://issues.jboss.org/browse/WFLY-10520
>             Project: WildFly
>          Issue Type: Task
>          Components: JPA / Hibernate
>            Reporter: Gail Badner
>            Assignee: Scott Marlow
>             Fix For: 14.0.0.CR1
>
>
> A compatibility transformer needs to be added to address Hibernate ORM 5.3 API methods that are no longer compatible with 5.1.
> From https://docs.google.com/document/d/1cAVBdeQXQfpTwH0f_GKSahh_gRd7bKI6kII-wxoMglU
> # Change calls to org.hibernate.BasicQueryContract.getFlushMode(), to instead call BasicQueryContract.getHibernateFlushMode().
> # Change calls to org.hibernate.Session.getFlushMode, to instead call Session.getHibernateFlushMode()
> # Change references to Enum org.hibernate.FlushMode.NEVER (0), to FlushMode.MANUAL (0). 
> # Change calls to org.hibernate.Query.getMaxResults() returning Integer, to instead call org.hibernate.Query.getHibernateMaxResults() (returning Integer).  
> # Change calls to org.hibernate.Query.setMaxResults(int), to instead call org.hibernate.Query.setHibernateMaxResults(int).
> # Change calls to org.hibernate.Query.getFirstResult(int) returning Integer, to instead call org.hibernate.Query.getHibernateFirstResult() (returning Integer).
> # Change calls to org.hibernate.Query.setFirstResult(int), to instead call org.hibernate.Query.setHibernateFirstResult(int).
> # Fill in rules here for UserType handling, which we are exploring still ([see list of methods in rejected ORM pr|https://github.com/hibernate/hibernate-orm/pull/2412/files]).



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)