[jboss-jira] [JBoss JIRA] (WFCORE-3977) Changing multicast address in socket binding does not trigger server to set reload-required

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13611716#comment-13611716 ] 

Brian Stansberry commented on WFCORE-3977:
------------------------------------------

[~pferraro] [~jmesnil] I've done some quick usage analysis of the SocketBindingManager stuff to get a sense of how often it's being done as intended.

tl;dr; Fairly often for unicast server sockets. Not always. AFAICT never for client sockets. Given how often it's not done right, and how fussy doing it right is, perhaps we should skip the isBound stuff and just rely on the service being UP/DOWN.

Probably the big difficulty in dropping SocketBindingManager altogether is the 'bound' attribute on the socket-binding=X resourcees.  Granted, the data it returns is often wrong, but that's the place where the original purpose of all this surfaces in our management API.

I've attached a usages search for ManagedBindingRegistry.registerBinding.  That shows where it looks to be being done  right.  The remoting subsystem stuff ends up being used by all our remoting connectors.  UnnamedManagedBindingRegistry is only used by UndertowHttpManagementService.  The SocketBinding.createXXXSocket methods, which IIRC was a key way services were intended to ensure the SBM got used, are not used at all.

> Changing multicast address in socket binding does not trigger server to set reload-required
> -------------------------------------------------------------------------------------------
>
>                 Key: WFCORE-3977
>                 URL: https://issues.jboss.org/browse/WFCORE-3977
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Management
>    Affects Versions: 6.0.0.Alpha3
>            Reporter: Richard Achmatowicz
>            Assignee: Jeff Mesnil
>         Attachments: WFCORE-3977_binding_usage.txt
>
>
> Found this by accident when debugging a clustering test case.
> If I start a server with profile standalone-full-ha and then modify the multicast address of a clustering related socket-binding, in this case, jgroups-mping, the server is not put into state reload-required.
> This causes a lot of problems in the testsuite which depends on configuring servers after startup and then restarting if necessary to pull in the changes.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)