[jboss-jira] [JBoss JIRA] (WFCORE-3897) Host starts with server assigned to non-existent server group

[Chao Wang (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586112#comment-13586112 ] 

Chao Wang commented on WFCORE-3897:
-----------------------------------

You're correct ! It is deliberately skipped as explained at [CapabilityRegistry resolveCapabilities()|https://github.com/wildfly/wildfly-core/blob/5.0.0.Final/controller/src/main/java/org/jboss/as/controller/CapabilityRegistry.java#L856-L864]

{code:java}
    // Missing
    if (hostXmlOnly && dependentName.startsWith("org.wildfly.domain.server-config.")
            && (req.getRequiredName().startsWith("org.wildfly.domain.server-group.")
            || req.getRequiredName().startsWith("org.wildfly.domain.socket-binding-group."))) {
        // HACK. We can't resolve these now as we have no domain model at this part of boot
        // We can resolve them when the domain model ops run, so wait to validate then
        ControllerLogger.MGMT_OP_LOGGER.tracef("Ignoring that dependent %s cannot resolve required capability %s as the 'hostXmlOnly' param is set", dependentId, req.getRequiredName());
        continue;
    }
{code}

About the expected ideal check based on available domain model, I don't quite understand OperationContextImpl.stageCompleted method:

{code:java}
    boolean stageCompleted(Stage stage) {
        return (stage != Stage.MODEL || validateCapabilities());
    }
{code}

If it's still at MODEL stage (read/write), domain model is not available for capability validation, if it's not at MODEL stage, validateCapabilities() is never called due to short-circuit evaluation.

> Host starts with server assigned to non-existent server group
> -------------------------------------------------------------
>
>                 Key: WFCORE-3897
>                 URL: https://issues.jboss.org/browse/WFCORE-3897
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 5.0.0.CR1
>            Reporter: Chao Wang
>            Assignee: Chao Wang
>
> Configuring a host with:
>  <server name="server-one" group="main-server-group" auto-start="false"/>
>         <server name="server-two" group="main-server-group" auto-start="false">
>             <socket-bindings port-offset="150"/>
>         </server>
> And no server-goup with that name in the domain.xml, the host starts and all management operations fail.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)