[jboss-jira] [JBoss JIRA] (WFLY-10188) Setting Undertow default server needs validation of provided server to avoid broken Wildfly configuration

[Stuart Douglas (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13588489#comment-13588489 ] 

Stuart Douglas commented on WFLY-10188:
---------------------------------------

I think the only proper way to fix this is to remove these defaults, and let the these default to null. The default should come from the default XML config instead.

I guess this means from a compatibility point of view:

- Change old parser version to explicitly add the defaults if they are missing, so older config files still work
- Update our default configs to include the defaults
- Add transformer to reject config for older hosts if default is not set
- Update all the runtime code to deal with the fact that it may now be null
- Figure out how to handle the case where this is actually null and a deployment has not explicitly targeted a server/host, I guess a deployment failure would make the most sense.

[~bstansberry] does this seem reasonable to you?



> Setting Undertow default server needs validation of provided server to avoid broken Wildfly configuration
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: WFLY-10188
>                 URL: https://issues.jboss.org/browse/WFLY-10188
>             Project: WildFly
>          Issue Type: Bug
>          Components: Web (Undertow)
>    Affects Versions: 12.0.0.Final
>            Reporter: Pavel Jelinek
>            Assignee: Stuart Douglas
>            Priority: Critical
>
> Undertow server needs default-host to be set to be able to be used as Undertow subsystem default-server otherwise Wildfly would not start due to:
> {code}
> ERROR [org.jboss.as.controller] (Controller Boot Thread) WFLYCTL0362: Capabilities required by resource '/subsystem=undertow' are not available:
>     org.wildfly.undertow.host.test-server.default-host; Possible registration points for this capability: 
> 		/subsystem=undertow/server=*/host=*
> {code}
> This is dangerous as after calling a {{reload}} operation, the server simply fails and crashes. One can accidentaly kill the server with this and \!manual\! fix is necessary to the configuration to be able to start server again.
> I think that there should be some check that configuration of the newly created server is complete and valid before it is set as a default server.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)