[jboss-jira] [JBoss JIRA] (WFLY-10520) Add Hibernate ORM 5.3 compatibility transformer

[Scott Marlow (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13590380#comment-13590380 ] 

Scott Marlow commented on WFLY-10520:
-------------------------------------

Questions/changes from [https://github.com/wildfly/wildfly/pull/11340] 

1.  Enum org.hibernate.FlushMode.NEVER (0) is deprecated in 5.1, and removed from 5.2; FlushMode.MANUAL (0) should be used instead.

Should the transformer change references to FlushMode.NEVER to FlushMode.MANUAL?

2.  ORM 5.1 applications may of seen null returned from org.hibernate.Query.getFirstResult(), under 5.3, applications will never see null.

How does 5.3 handle the same 5.1 conditions that caused getFirstResult() to previously return null?  We should document this.

3.  ORM 5.1 applications may of seen -1 returned from from org.hibernate.Query.getFirstResult(), under 5.3, applications will never see -1, instead 5.3 will throw an IllegalStateException when a negative number is passed to setFirstResult().  

It sounds like the transformer will not ever see the condition where getFirstResult would return -1, since that is not allowed.

4. In 5.3, Integer.MAX_VALUE will be returned from Query.getMaxResults(), the transformer should also check for this value and replace with null reference.


> Add Hibernate ORM 5.3 compatibility transformer
> -----------------------------------------------
>
>                 Key: WFLY-10520
>                 URL: https://issues.jboss.org/browse/WFLY-10520
>             Project: WildFly
>          Issue Type: Task
>          Components: JPA / Hibernate
>            Reporter: Gail Badner
>            Assignee: Scott Marlow
>             Fix For: 14.0.0.CR1
>
>
> A compatibility transformer needs to be added to address Hibernate ORM 5.3 API methods that are no longer compatible with 5.1.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)