[jboss-jira] [JBoss JIRA] (WFLY-10520) Add Hibernate ORM 5.3 compatibility transformer

[Scott Marlow (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592880#comment-13592880 ] 

Scott Marlow commented on WFLY-10520:
-------------------------------------

We are now replacing FlushMode.NEVER with FlushMode.DEFAULT. 

Updated server.log output with just transformation info:
{quote}
grep Hibernate51CompatibilityTransformer ../standalone/log/server.log 
2018-06-18 14:37:05,375 DEBUG [org.jboss.as.jpa] (MSC service thread 1-6) Hibernate51CompatibilityTransformer transforming deployment class org/jboss/as/test/compat/jpa/hibernate/transformer/SFSBHibernateSessionFactory from classloader ModuleClassLoader for Module "deployment.VerifyHibernate51CompatibilityTestCase.ear.beans.jar" from Service Module Loader
2018-06-18 14:37:05,396 DEBUG [org.jboss.as.jpa] (MSC service thread 1-6) Hibernate51CompatibilityTransformer change getFlushMode call to getHibernateFlushMode
2018-06-18 14:37:05,396 DEBUG [org.jboss.as.jpa] (MSC service thread 1-6) Hibernate51CompatibilityTransformer change getFlushMode call to getHibernateFlushMode
2018-06-18 14:37:05,397 DEBUG [org.jboss.as.jpa] (MSC service thread 1-6) Hibernate51CompatibilityTransformer for getFirstResult/getMaxResults calls, convert 'int' to 'Integer'
2018-06-18 14:37:05,397 DEBUG [org.jboss.as.jpa] (MSC service thread 1-6) Hibernate51CompatibilityTransformer for getFirstResult/getMaxResults calls, convert 'int' to 'Integer'
2018-06-18 14:37:06,103 DEBUG [org.jboss.as.jpa] (pool-7-thread-1) Hibernate51CompatibilityTransformer transforming deployment class org/jboss/as/test/compat/jpa/hibernate/transformer/VerifyHibernate51CompatibilityTestCase from classloader ModuleClassLoader for Module "deployment.VerifyHibernate51CompatibilityTestCase.ear.main.war" from Service Module Loader
2018-06-18 14:37:06,104 DEBUG [org.jboss.as.jpa] (pool-7-thread-1) Hibernate51CompatibilityTransformer change org.hibernate.FlushMode.NEVER to org.hibernate.FlushMode.FlushMode.MANUAL
2018-06-18 14:37:06,104 DEBUG [org.jboss.as.jpa] (pool-7-thread-1) Hibernate51CompatibilityTransformer change org.hibernate.FlushMode.NEVER to org.hibernate.FlushMode.FlushMode.MANUAL
2018-06-18 14:37:06,104 DEBUG [org.jboss.as.jpa] (pool-7-thread-1) Hibernate51CompatibilityTransformer change org.hibernate.FlushMode.NEVER to org.hibernate.FlushMode.FlushMode.MANUAL
2018-06-18 14:37:06,104 DEBUG [org.jboss.as.jpa] (pool-7-thread-1) Hibernate51CompatibilityTransformer change org.hibernate.FlushMode.NEVER to org.hibernate.FlushMode.FlushMode.MANUAL
{quote}

And remaining test failures are shown at [https://paste.fedoraproject.org/paste/S8dvCuSKPAXWcoMD2sC2pA]


> Add Hibernate ORM 5.3 compatibility transformer
> -----------------------------------------------
>
>                 Key: WFLY-10520
>                 URL: https://issues.jboss.org/browse/WFLY-10520
>             Project: WildFly
>          Issue Type: Task
>          Components: JPA / Hibernate
>            Reporter: Gail Badner
>            Assignee: Scott Marlow
>             Fix For: 14.0.0.CR1
>
>
> A compatibility transformer needs to be added to address Hibernate ORM 5.3 API methods that are no longer compatible with 5.1.
> From https://docs.google.com/document/d/1cAVBdeQXQfpTwH0f_GKSahh_gRd7bKI6kII-wxoMglU
> # Change call to org.hibernate.BasicQueryContract.getFlushMode() to instead call BasicQueryContract.getHibernateFlushMode().
> # Change call to org.hibernate.Session.getFlushMode, to instead call Session.getHibernateFlushMode()
> # Modify calls to org.hibernate.Query.getFirstResult() to convert returned int, to Integer result.
> # Modify calls to org.hibernate.Query.getMaxResults() to convert returned int, to Integer result, if returned int value is <= 0, null should be used, if Integer.MAX_VALUE is, the transformer should replace with null reference.
> # App References to Enum org.hibernate.FlushMode.NEVER (0) should be transformed to reference FlushMode.MANUAL (0) instead.   



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)