[jboss-jira] [JBoss JIRA] (WFLY-10475) JSF installer module definitions are not synced with JSF modules

[Jan Blizňák (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-10475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13594888#comment-13594888 ] 

Jan Blizňák edited comment on WFLY-10475 at 6/21/18 5:36 AM:
-------------------------------------------------------------

[~treblereel] I see, you fixed the issue with incorrect XML files in WFLY-10567, thanks.

I checked again the current state of:
https://github.com/wildfly/wildfly/tree/master/jsf/multi-jsf-installer/src/main/resources
and
https://github.com/wildfly/wildfly/blob/master/feature-pack/src/main/resources/modules/system/layers/base/javax/faces/api/main/module.xml
https://github.com/wildfly/wildfly/blob/master/feature-pack/src/main/resources/modules/system/layers/base/com/sun/jsf-impl/main/module.xml
https://github.com/wildfly/wildfly/blob/master/feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/jsf-injection/main/module.xml

Ignoring the EE8 preview switch, which would eventually go away, there is one more difference I'd like to be solved, the dependency on org.omg.api module:
https://github.com/wildfly/wildfly/blob/master/jsf/multi-jsf-installer/src/main/resources/mojarra-impl-module.xml#L44
https://github.com/wildfly/wildfly/blob/master/jsf/multi-jsf-installer/src/main/resources/myfaces-impl-module.xml#L57
https://github.com/wildfly/wildfly/blob/master/feature-pack/src/main/resources/modules/system/layers/base/com/sun/jsf-impl/main/module.xml#L44


Judging from https://github.com/wildfly/wildfly/pull/11279/files, this should go away.


was (Author: jbliznak):
[~treblereel] I see, you fixed the issue with incorrect XML files in WFLY-10567, thanks.

I checked again the current state of:
https://github.com/wildfly/wildfly/tree/master/jsf/multi-jsf-installer/src/main/resources
and
https://github.com/wildfly/wildfly/blob/master/feature-pack/src/main/resources/modules/system/layers/base/javax/faces/api/main/module.xml
https://github.com/wildfly/wildfly/blob/master/feature-pack/src/main/resources/modules/system/layers/base/com/sun/jsf-impl/main/module.xml
https://github.com/wildfly/wildfly/blob/master/feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/jsf-injection/main/module.xml

Ignoring the EE8 preview switch, which would eventually go away, there is one more difference I'd like to be solved, the dependency on org.omg.api module:
https://github.com/wildfly/wildfly/blob/master/jsf/multi-jsf-installer/src/main/resources/mojarra-impl-module.xml#L44
https://github.com/wildfly/wildfly/blob/master/feature-pack/src/main/resources/modules/system/layers/base/com/sun/jsf-impl/main/module.xml#L44

Judging from https://github.com/wildfly/wildfly/pull/11279/files, this should go away too.

> JSF installer module definitions are not synced with JSF modules
> ----------------------------------------------------------------
>
>                 Key: WFLY-10475
>                 URL: https://issues.jboss.org/browse/WFLY-10475
>             Project: WildFly
>          Issue Type: Bug
>          Components: JSF
>    Affects Versions: 13.0.0.Final
>            Reporter: Jan Blizňák
>            Assignee: Dmitrii Tikhomirov
>             Fix For: 14.0.0.CR1
>
>
> There is a JSF installer module resources https://github.com/wildfly/wildfly/tree/master/jsf/multi-jsf-installer/src/main/resources which seem to be out of sync with the JSF modules defined in feature-pack:
> https://github.com/wildfly/wildfly/blob/master/feature-pack/src/main/resources/modules/system/layers/base/javax/faces/api/main/module.xml
> https://github.com/wildfly/wildfly/blob/master/feature-pack/src/main/resources/modules/system/layers/base/com/sun/jsf-impl/main/module.xml
> https://github.com/wildfly/wildfly/blob/master/feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/jsf/main/module.xml
> https://github.com/wildfly/wildfly/blob/master/feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/jsf-injection/main/module.xml
> I guess these should be synced, ie. changes from feature-pack should be reflected in JSF installer too.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)