[jboss-jira] [JBoss JIRA] (WFLY-10520) Add Hibernate ORM 5.3 compatibility transformer

[Scott Marlow (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13595756#comment-13595756 ] 

Scott Marlow commented on WFLY-10520:
-------------------------------------

Currently, they are a combination of INFO and WARNING level messages.  [https://github.com/scottmarlow/wildfly/blob/WFLY-10520_hibernatecompatabilitytransformer/jpa/subsystem/src/main/java/org/jboss/as/jpa/messages/JpaLogger.java#L770].

One advantage of making them trace, is they then wouldn't need to be translated to other languages.  

[~gbadner] what do you think about making these messages TRACE level, versus WARNING?  I think that you said something before on chat, about how the user should be warned that they need to update their application.

One advantage of WARNINGS, is that they will show up in the server console until the application is rewritten and the transformer disabled, so they act as a PITA console messages that probably appear thousands of times, depending on the app.  It is also true, that when we log a message, thousands of times, we may as well not bother, as there are too many messages to read.  Tough to decide, but filling the disk with too many log messages, is also a big problem problem, imo.

> Add Hibernate ORM 5.3 compatibility transformer
> -----------------------------------------------
>
>                 Key: WFLY-10520
>                 URL: https://issues.jboss.org/browse/WFLY-10520
>             Project: WildFly
>          Issue Type: Task
>          Components: JPA / Hibernate
>            Reporter: Gail Badner
>            Assignee: Scott Marlow
>             Fix For: 14.0.0.CR1
>
>
> A compatibility transformer needs to be added to address Hibernate ORM 5.3 API methods that are no longer compatible with 5.1.
> From https://docs.google.com/document/d/1cAVBdeQXQfpTwH0f_GKSahh_gRd7bKI6kII-wxoMglU
> # Change call to org.hibernate.BasicQueryContract.getFlushMode() to instead call BasicQueryContract.getHibernateFlushMode().
> # Change call to org.hibernate.Session.getFlushMode, to instead call Session.getHibernateFlushMode()
> # Modify calls to org.hibernate.Query.getFirstResult() to convert returned int, to Integer result.
> # Modify calls to org.hibernate.Query.getMaxResults() to convert returned int, to Integer result, if returned int value is <= 0, null should be used, if Integer.MAX_VALUE is, the transformer should replace with null reference.
> # App References to Enum org.hibernate.FlushMode.NEVER (0) should be transformed to reference FlushMode.MANUAL (0) instead.   
> # For call to org.hibernate.Query.setMaxResults(int), instead call org.hibernate.Query.setHibernateMaxResults(int) which will be added soon to ORM 5.3.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)