[jboss-jira] [JBoss JIRA] (WFLY-10520) Add Hibernate ORM 5.3 compatibility transformer

[Gail Badner (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13596597#comment-13596597 ] 

Gail Badner commented on WFLY-10520:
------------------------------------

[~smarlow], I've pushed my fix for HHH-12729 to https://github.com/gbadner/hibernate-core/tree/HHH-12729 .

I still need to add more information to the description for HHH-12729 and add a commit updating the migration guide before creating a PR.

I've also created a PR for your WFLY-10520_hibernatecompatabilitytransformer branch:
https://github.com/scottmarlow/wildfly/pull/18

If you build my PR using my HHH-12729  branch, you will see that all tests pass except 1, testORA5_3_1_Compatibility_getFirstResultNegative(). That test fails because setHibernateFirstResult( -1) will actually set the value to 0. In 5.1, a negative value was actually set; we can't do that in 5.3 though. IMO, this could be documented in the migration guide. In this case, Hibernate will start results from position 0, just as was done in 5.1.

> Add Hibernate ORM 5.3 compatibility transformer
> -----------------------------------------------
>
>                 Key: WFLY-10520
>                 URL: https://issues.jboss.org/browse/WFLY-10520
>             Project: WildFly
>          Issue Type: Task
>          Components: JPA / Hibernate
>            Reporter: Gail Badner
>            Assignee: Scott Marlow
>             Fix For: 14.0.0.CR1
>
>
> A compatibility transformer needs to be added to address Hibernate ORM 5.3 API methods that are no longer compatible with 5.1.
> From https://docs.google.com/document/d/1cAVBdeQXQfpTwH0f_GKSahh_gRd7bKI6kII-wxoMglU
> # Change call to org.hibernate.BasicQueryContract.getFlushMode() to instead call BasicQueryContract.getHibernateFlushMode().
> # Change call to org.hibernate.Session.getFlushMode, to instead call Session.getHibernateFlushMode()
> # Modify calls to org.hibernate.Query.getFirstResult() to convert returned int, to Integer result.
> # Modify calls to org.hibernate.Query.getMaxResults() to convert returned int, to Integer result, if returned int value is <= 0, null should be used, if Integer.MAX_VALUE is, the transformer should replace with null reference.
> # App References to Enum org.hibernate.FlushMode.NEVER (0) should be transformed to reference FlushMode.MANUAL (0) instead.   
> # For call to org.hibernate.Query.setMaxResults(int), instead call org.hibernate.Query.setHibernateMaxResults(int) which will be added soon to ORM 5.3.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)