[jboss-jira] [JBoss JIRA] (WFLY-10640) driver-datasource-class-name and driver-xa-datasource-class-name need to be validated when updating

[Lin Gao (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-10640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597516#comment-13597516 ] 

Lin Gao commented on WFLY-10640:
--------------------------------

[~maeste] Do you see any problem if only valid +javax.sql.DataSource+ / +javax.sql.XADataSource+ implementation can be specified when updating the JDBC driver or adding the datasource? For now, I can see that the smoke test [DataSourceOperationsUnitTestCase#testAddXaDsWithProperties|https://github.com/wildfly/wildfly/blob/13.0.0.Final/testsuite/integration/smoke/src/test/java/org/jboss/as/test/smoke/mgmt/datasource/DataSourceOperationsUnitTestCase.java#L348]  will fail.

> driver-datasource-class-name and driver-xa-datasource-class-name need to be validated when updating
> ---------------------------------------------------------------------------------------------------
>
>                 Key: WFLY-10640
>                 URL: https://issues.jboss.org/browse/WFLY-10640
>             Project: WildFly
>          Issue Type: Bug
>          Components: JCA
>            Reporter: Lin Gao
>            Assignee: Lin Gao
>            Priority: Minor
>
> Download oracle jdbc driver at http://www.oracle.com/technetwork/database/features/jdbc/jdbc-ucp-122-3110062.html
> Install the driver as a module and add the JDBC driver:
> {code:bash}
> module add --name=com.oracle.jdbc --resources=/opt/Downloads/ojdbc8.jar --dependencies=[javax.api, javax.transaction.api]
> /subsystem=datasources/jdbc-driver=oracle:add(driver-name=oracle, driver-module-name=com.oracle.jdbc, driver-datasource-class-name=oracle.jdbc.datasource.OracleDataSource, driver-xa-datasource-class-name=oracle.jdbc.xa.client.OracleXADataSource, driver-class-name=oracle.jdbc.OracleDriver)
> {code}
> It should fail because the configuraiton:
> {code:java}
> driver-datasource-class-name=oracle.jdbc.datasource.OracleDataSource
> {code}
> is wrong, +oracle.jdbc.datasource.OracleDataSource+ is an interface, not a concrete class.
> It should be the same for the data-source creation when specifying the datasource-class.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)