[jboss-jira] [JBoss JIRA] (WFLY-10014) Unable to configure comma delimited enabled-protocols in remote-connector

[Miroslav Novak (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13545728#comment-13545728 ] 

Miroslav Novak edited comment on WFLY-10014 at 3/14/18 9:13 AM:
----------------------------------------------------------------

Artemis 1.5.5.009 is missing:
{code}
 /**
       * Some configuration values can contain commas (e.g. enabledProtocols, enabledCipherSuites, etc.).
       * To support config values with commas, the commas in the values must be escaped (e.g. "\\,") so that
       * the commas used to separate configs for different connectors can still function as designed.
       */
      String commaPlaceHolder = UUID.randomUUID().toString();
String replaced = config.replace("\\,", commaPlaceHolder);
...
{code}

 in ActiveMQRaUtils.parseConfig(). Looks like there was a fix for this to Artemis 2.x but was not backported to Artemis 1.x.

Compare:
https://github.com/rh-messaging/jboss-activemq-artemis/blob/1.5.5.jbossorg-009/artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQRaUtils.java#L191

and

https://github.com/apache/activemq-artemis/blob/master/artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQRaUtils.java#L191


was (Author: mnovak):
Artemis 1.5.5.009 is missing:
{code}
 /**
       * Some configuration values can contain commas (e.g. enabledProtocols, enabledCipherSuites, etc.).
       * To support config values with commas, the commas in the values must be escaped (e.g. "\\,") so that
       * the commas used to separate configs for different connectors can still function as designed.
       */
      String commaPlaceHolder = UUID.randomUUID().toString();
String replaced = config.replace("\\,", commaPlaceHolder);
...
{code}

 in ActiveMQRaUtils.parseConfig(). Looks like there was a fix for this to Artemis 2.x but was not backported to Artemis 1.x.

> Unable to configure comma delimited enabled-protocols in remote-connector
> -------------------------------------------------------------------------
>
>                 Key: WFLY-10014
>                 URL: https://issues.jboss.org/browse/WFLY-10014
>             Project: WildFly
>          Issue Type: Bug
>          Components: JMS
>    Affects Versions: 12.0.0.Final
>            Reporter: Nagaraju Chitimilla
>            Assignee: Jeff Mesnil
>            Priority: Critical
>
> When I want to configure enabled SSL protocols, Netty requires to use comma delimited list to be passed into enabled-protocols param in remote-connector
> {noformat}
> <param name="enabled-protocols" value="TLSv1.1,TLSv1.2"/>
> {noformat}
> But when comma is used in value in configuration string passed into ActiveMQRaUtils.parseConfig, parsing fails:
> {code:java}
> Caused by: java.lang.IllegalArgumentException: Invalid expression TLSv1.2 at enabledProtocols=TLSv1.1,TLSv1.2;trustStorePassword=N0tall0wed;keyStorePassword=N0tall0wed;port=61616;localAddress=0.0.0.0;sslEnabled=true;host=localhost;trustStorePath=C:/ActiveMQ/conf/keystore.p12;keyStorePath=C:/ActiveMQ/conf/keystore.p12  
>         at org.apache.activemq.artemis.ra.ActiveMQRaUtils.parseConfig(ActiveMQRaUtils.java:205)  
>         at org.apache.activemq.artemis.ra.ActiveMQResourceAdapter.setConnectionParameters(ActiveMQResourceAdapter.java:342)  
>         ... 18 more  
> {code}
> I set this as critical as it prevent setting more then one allowed SSLContext protocol. 



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)