[jboss-jira] [JBoss JIRA] (WFCORE-3718) mvn versions:set -DnewVersion=xxxx does not replace component-matrix/pom.xml

[Jeff Mesnil (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-3718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554427#comment-13554427 ] 

Jeff Mesnil commented on WFCORE-3718:
-------------------------------------

I have restored https://developer.jboss.org/wiki/WildFlyCoreReleaseProcess to using sed instructions.

However, I think this is not a bug in mvn versions plugin.

* wildfly-core-parent has *no* dependency on component-matrix (it is listed in the dependencyManagement with a scope import)
* component-matrix is a module of wildfly-core-parent
* component-matrix parent is org.jboss:jboss-parent while every other modules in core has org.wildfly.core:wildfly-core-parent has a module
* component-matrix defines its groupId and version while every other modules in core inherits this value from org.wildfly.core:wildfly-core-parent

According to https://www.mojohaus.org/versions-maven-plugin/set-mojo.html, the version is changed for modules only when they have a parent/child relation to the main module (which is not the case for component-matrix).
So I think that the mvn versions plugin is right when it does not update the component-matrix as it is not a child of  org.wildfly.core:wildfly-core-parent :)

If we wanted to use the mvn version plugins, we would have to use mvn versions:set -DnewVersion=XXX -DprocessAllModules=true


> mvn versions:set -DnewVersion=xxxx does not replace component-matrix/pom.xml
> ----------------------------------------------------------------------------
>
>                 Key: WFCORE-3718
>                 URL: https://issues.jboss.org/browse/WFCORE-3718
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Domain Management
>    Affects Versions: 5.0.0.Alpha2
>            Reporter: Kabir Khan
>            Assignee: Tomaz Cerar
>
> {quote}
> [2:26 PM] Kabir Khan: @ctomc following https://developer.jboss.org/wiki/WildFlyCoreReleaseProcess, and using 
> mvn versions:set -DnewVersion=5.0.0.Alpha2
> [2:26 PM] Kabir Khan: it seems to keep component-matrix/pom.xml as -SNAPSHOT
> [2:26 PM] Kabir Khan: $git grep "\-SNAPSHOT"  
> component-matrix/pom.xml:    <version>5.0.0.Alpha2-SNAPSHOT</version>
> [2:27 PM] Tomaz Cerar: damn, that is not good
> [2:27 PM] Tomaz Cerar: versions plugin is bit stupid in some cases
> [2:27 PM] Kabir Khan: Should it be in the list of modules?
> [2:27 PM] Tomaz Cerar: it is
> {quote}
> All other versions are correctly replaced. I'd hazard a guess that this also happens in WF full.
> CC [~brian.stansberry] - for the 5.0.0.Alpha2 release I'm using the old find/sed way



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)