[jboss-jira] [JBoss JIRA] (WFLY-10348) Picketlink federation XML writer should not rely on the ordering in the ModelNode

[Martin Choma (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-10348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574818#comment-13574818 ] 

Martin Choma commented on WFLY-10348:
-------------------------------------

I have run through security related subsystems and same approach is used in IDMSubsystemWriter. But there is only one child element so it is safe :)

> Picketlink federation XML writer should not rely on the ordering in the ModelNode
> ---------------------------------------------------------------------------------
>
>                 Key: WFLY-10348
>                 URL: https://issues.jboss.org/browse/WFLY-10348
>             Project: WildFly
>          Issue Type: Bug
>          Components: Security
>            Reporter: Alexey Loubyansky
>            Assignee: Darran Lofthouse
>
> AFAICS, FederationSubsystemWriter is relying on the ordering of the children of the root ModelNode when persisting the subsystem configuration. If one was to create a configuration using management operations from scratch, the operations would have to be ordered according to the order of the corresponding elements defined in the XSD schema. Which is not very practical and increases the chance of getting errors that could be avoided by making the writer persist the elements in the valid order.
> E.g. in the current implementation if a management operation configuring key-store appeared after the one(s) configuring service-providers the resulting subsystem XML would be invalid according to the XSD.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)