[jboss-jira] [JBoss JIRA] (WFLY-10339) Broadcast/discovery-group resources have ambiguous requirement specs

[Jeff Mesnil (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575630#comment-13575630 ] 

Jeff Mesnil commented on WFLY-10339:
------------------------------------

[~pferraro] thanks for looking at it.

I agree that we can split the resources as they have quite different cap/reqs.

Could I suggest that we keep the <broadcast|discovery>-group for the JGroups implementation (which is the default we use)?
The socket-based version would be named socket-broadcast-group as you suggest.

Note that this has an impact on the legacy messaging migration. if the socket version is used, the migrated add operation will have to use the new resource name at https://github.com/wildfly/wildfly/blob/f4b6b3afdea148862a28b34082c8dd215fa77607/legacy/messaging/src/main/java/org/jboss/as/messaging/MigrateOperation.java#L493.

Please note that I am about to revert the management version bump of the messaging-activemq subsystem as there has been no management changes between WildFly 12 and 13.
If you plan to do that *before* WildFly 13, please tell me so that I cancel the revert.

thanks!

> Broadcast/discovery-group resources have ambiguous requirement specs
> --------------------------------------------------------------------
>
>                 Key: WFLY-10339
>                 URL: https://issues.jboss.org/browse/WFLY-10339
>             Project: WildFly
>          Issue Type: Bug
>          Components: JMS
>    Affects Versions: 12.0.0.Final
>            Reporter: Paul Ferraro
>            Assignee: Jeff Mesnil
>
> Currently, the broadcast/discovery-group resources have messy requirement specs, as the capabilities that they require are dependent whether or not the jgroups-cluster attribute is defined.
> I suggest splitting these resources into 2:
> {code}/subsystem=messaging-activemq/server=*/jgroups-broadcast-group=*{code}
> {code}/subsystem=messaging-activemq/server=*/jgroups-discovery-group=*{code}
> which requires clustering capabilities
> and
> {code}/subsystem=messaging-activemq/server=*/socket-broadcast-group=*{code}
> {code}/subsystem=messaging-activemq/server=*/socket-discovery-group=*{code}
> which requires a socket-binding capability.
> This results in clearer requirement specs - which helps simplify the introspection of this subsystem for provisioning purposes.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)