[jboss-jira] [JBoss JIRA] (WFLY-10329) Have JipiJapa enable Hibernate Search backward compatibility properties

[Scott Marlow (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-10329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13579081#comment-13579081 ] 

Scott Marlow commented on WFLY-10329:
-------------------------------------

Regarding adding a test, would that be testing that Search is properly logging a warning, to make sure that a Hibernate Search developer doesn't remove the warning?  If yes, that kind of test could probably be in the Hibernate Search project?  Or maybe covered by a comment in Search code, to not ever remove the warning?

For the documentation, is that covered already in Hibernate Search documentation?

I'll mark this as closed, since I can see in the WF source org.jboss.as.jpa.hibernate5.HibernatePersistenceProviderAdaptor.addProviderProperties, 
{code}
     // Search hint
     putPropertyIfAbsent( pu, properties,"hibernate.search.index_uninverting_allowed", true);
{code}

> Have JipiJapa enable Hibernate Search backward compatibility properties
> -----------------------------------------------------------------------
>
>                 Key: WFLY-10329
>                 URL: https://issues.jboss.org/browse/WFLY-10329
>             Project: WildFly
>          Issue Type: Task
>            Reporter: Sanne Grinovero
>            Assignee: Scott Marlow
>             Fix For: 13.0.0.Beta1
>
>
> For Hibernate Search 5.10.x to be fully backwards compatible with the previous versions included in WildFly, we need the following property to be set by default among the Hibernate ORM configuration properties:
> {code}
> hibernate.search.index_uninverting_allowed=true
> {code}
> When set to true and the mapping actually makes use of this feature, a warning will be logged.
> We probably will want to document this as well: recommend users to set it to "false" explicitly, as relying on this feature has a performance penalty, yet no relying on it requires mapping changes.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)