[jboss-jira] [JBoss JIRA] (WFLY-10339) Broadcast/discovery-group resources have ambiguous requirement specs

[Paul Ferraro (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580526#comment-13580526 ] 

Paul Ferraro edited comment on WFLY-10339 at 5/22/18 5:01 PM:
--------------------------------------------------------------

[~eduda] I do not intend to require a migration operation.  This change should be entirely achievable using normal resource/operation transformations and operation translations.

[~jmesnil] I'll plan to address this for WF14.

{quote}Could I suggest that we keep the <broadcast|discovery>-group for the JGroups implementation (which is the default we use)?{quote}
I would actually recommend against that.  Using new path names for both resources makes it easy to distinguish between a legacy CLI command and one intended for the current version of the model - especially since the resource in question heavily relies on optional attributes.  This way we can replace the add/remove operation handling with an implementation that redirects/translates the operation to the correct path address.  WDYT?


was (Author: pferraro):
[~eduda] I do not intend to require a migration operation.  This change should be entirely achievable using normal resource/operation transformations and operation translations.

[~jmesnil] I'll plan to address this for WF14.

{quote}Could I suggest that we keep the <broadcast|discovery>-group for the JGroups implementation (which is the default we use)?{quote}
I would actually recommend against that.  Use new path names for both resources makes it easy to distinguish between a legacy CLI command and one intended for the current version of the model - especially since the resource in question heavily relies on non-required attributes.  This way we can replace the add/remove operation handling with an implementation that redirects/translates the operation to the correct path address.  WDYT?

> Broadcast/discovery-group resources have ambiguous requirement specs
> --------------------------------------------------------------------
>
>                 Key: WFLY-10339
>                 URL: https://issues.jboss.org/browse/WFLY-10339
>             Project: WildFly
>          Issue Type: Bug
>          Components: JMS
>    Affects Versions: 12.0.0.Final
>            Reporter: Paul Ferraro
>            Assignee: Jeff Mesnil
>
> Currently, the broadcast/discovery-group resources have messy requirement specs, as the capabilities that they require are dependent whether or not the jgroups-cluster attribute is defined.
> I suggest splitting these resources into 2:
> {code}/subsystem=messaging-activemq/server=*/jgroups-broadcast-group=*{code}
> {code}/subsystem=messaging-activemq/server=*/jgroups-discovery-group=*{code}
> which requires clustering capabilities
> and
> {code}/subsystem=messaging-activemq/server=*/socket-broadcast-group=*{code}
> {code}/subsystem=messaging-activemq/server=*/socket-discovery-group=*{code}
> which requires a socket-binding capability.
> This results in clearer requirement specs - which helps simplify the introspection of this subsystem for provisioning purposes.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)