[jboss-jira] [JBoss JIRA] (WFLY-10446) Register undertow deployment services under the deployment service name
Peter Palaga (JIRA)
issues at jboss.org
Wed May 30 07:39:00 EDT 2018
[ https://issues.jboss.org/browse/WFLY-10446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584250#comment-13584250 ]
Peter Palaga commented on WFLY-10446:
-------------------------------------
Citing [~swd847] https://github.com/wildfly/wildfly/pull/11274#issuecomment-392419012
{quote}
I don't really see any reason for the deployment service name to be this complex. I think it should just be changed to be prefixed on deploymentUnit.getServiceName() like almost every other deployment based service.
If we allow this PR in then we are kind of stuck with doing it the way we currently are, as it becomes a bit of an API, so I would prefer that the current code is modified to register the deployment info service under a more appropriate service name.
{quote}
There is a new PR by Stuart: https://github.com/wildfly/wildfly/pull/11298
> Register undertow deployment services under the deployment service name
> -----------------------------------------------------------------------
>
> Key: WFLY-10446
> URL: https://issues.jboss.org/browse/WFLY-10446
> Project: WildFly
> Issue Type: Task
> Components: Web (Undertow)
> Reporter: Peter Palaga
> Assignee: Peter Palaga
>
> To be able to secure Camel CXF endpoints in WildFly Camel, we need an access to DeploymentInfo produced by UndertowDeploymentInfoService. Currently, the service name of UndertowDeploymentInfoService is assembled out of several parts including server name, host name and deployment name. These three are defined by a complex logic that checks various sources and defaults. So, rather than copying that logic to WildFly Camel, we'd like to pack those names into a data object and attach it to the deploymentUnit so that it is available to our DeploymentProcessor.
> A PR follows.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
More information about the jboss-jira
mailing list