[jboss-jira] [JBoss JIRA] (DROOLS-3225) [DMN Designer] Decision table output data type is not stored

[Jozef Marko (Jira)]

    [ https://issues.jboss.org/browse/DROOLS-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655892#comment-13655892 ] 

Jozef Marko commented on DROOLS-3225:
-------------------------------------

[~tari_manga] ok, will try to clarify, with DMN PRs I usually try to use created DMN also in runtime, even if touched code is on client side.

Trying running some DMN decision tables I spotted xml you highlighted in the [comment|https://github.com/kiegroup/drools/pull/2123#pullrequestreview-170776915]. As you said in that [comment|https://github.com/kiegroup/drools/pull/2123#pullrequestreview-170776915] you will touch code that generates it, so I marked this issue and your [comment|https://github.com/kiegroup/drools/pull/2123#pullrequestreview-170776915] as related things.

Not saying you have to fix DROOLS-3225. Anyway I have already approved DROOLS-3225 and filed DROOLS-3227 as corollary. And again, let me clarify, I do not expect you will fix DROOLS-3227, but think during its verification I can spot things related to the [comment|https://github.com/kiegroup/drools/pull/2123#pullrequestreview-170776915].

> [DMN Designer] Decision table output data type is not stored
> ------------------------------------------------------------
>
>                 Key: DROOLS-3225
>                 URL: https://issues.jboss.org/browse/DROOLS-3225
>             Project: Drools
>          Issue Type: Bug
>          Components: DMN Editor
>    Affects Versions: 7.14.0.Final
>            Reporter: Jozef Marko
>            Assignee: Michael Anstis
>            Priority: Blocker
>              Labels: drools-tools
>         Attachments: Screenshot from 2018-11-01 10-59-08.png, Screenshot from 2018-11-01 15-31-19.png, job-interview.dmn
>
>
> Issue spotted during DROOLS-3214, however probably not related.
> If decision table output data type is changed, the change is not reflected in the xml.
> Please follow my steps:
> - Create new DMN diagram
> - Add a decision node
> - Set the decision node top level expression as a decision table
> - Double click on Output header cell
> - Select boolean lets say
> - Save the diagram
> Check the source, there will be still stored string output data type, like below:
> {code:xml}
> <dmn:decisionTable id="_DE6CDA18-99D1-4259-9F6D-825209DF7DE8" typeRef="string" hitPolicy="ANY" preferredOrientation="Rule-as-Row">
>       <dmn:input id="_EB7B7C02-4131-468C-B1B1-023C39045B66">
>         <dmn:inputExpression id="_C72A9C94-130C-4BA5-A529-49BAE217DDFF" typeRef="string">
>           <dmn:text>input-1</dmn:text>
>         </dmn:inputExpression>
>         <dmn:inputValues id="_1EC58DD6-21EB-4822-A333-581363BC325B">
>           <dmn:text></dmn:text>
>         </dmn:inputValues>
>       </dmn:input>
>       <dmn:output id="_81248A6E-0239-404A-B891-C7C0BEE6B501" name="output-1" typeRef="string">
>         <dmn:outputValues id="_26301186-9EB2-43E8-B6F8-458361E99B45">
>           <dmn:text></dmn:text>
>         </dmn:outputValues>
>         <dmn:defaultOutputEntry id="_EAC89F66-3B9E-4781-B670-1282975F4F1E" typeRef="string">
>           <dmn:text></dmn:text>
>         </dmn:defaultOutputEntry>
>       </dmn:output>
>       <dmn:rule id="_EC0CEE6B-E4D5-4DE2-9EE5-86C955933B4E">
>         <dmn:inputEntry id="_91AA6110-0A85-4C95-B0B3-D1B084CB0089">
>           <dmn:text>"you are right"</dmn:text>
>         </dmn:inputEntry>
>         <dmn:outputEntry id="_6FACD1CE-8301-413E-8C77-F04AD71B3C78" typeRef="string">
>           <dmn:text>true</dmn:text>
>         </dmn:outputEntry>
>       </dmn:rule>
>     </dmn:decisionTable>
>   </dmn:decision>
> {code}
> But the UI is like:
>  !Screenshot from 2018-11-01 10-59-08.png|thumbnail! 



--
This message was sent by Atlassian Jira
(v7.12.1#712002)