[jboss-jira] [JBoss JIRA] (WFWIP-142) Vendor metrics - loaded_modules reports incorrect value

[Jeff Mesnil (Jira)]

    [ https://issues.jboss.org/browse/WFWIP-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13657327#comment-13657327 ] 

Jeff Mesnil commented on WFWIP-142:
-----------------------------------

the ObjectName in io/smallrye/metrics/vendor-metrics.properties was wrong.
It should be jboss.modules:type=ModuleLoader,name=LocalModuleLoader-3 (and it reports ~300 modules).

However, [~dmlloyd] confirmed to me that the ObjectName can change (the increment at the end can be -3 or -4, etc. depending on config and race conditions.

We should not rely on JMX to get the number of modules. Instead, we could implement our own gauge that get the number directly from the correct ModuleLoader

> Vendor metrics - loaded_modules reports incorrect value
> -------------------------------------------------------
>
>                 Key: WFWIP-142
>                 URL: https://issues.jboss.org/browse/WFWIP-142
>             Project: WildFly WIP
>          Issue Type: Bug
>          Components: MP Metrics
>            Reporter: Rostislav Svoboda
>            Assignee: Jeff Mesnil
>            Priority: Blocker
>
> Vendor metrics - loaded_modules reports incorrect value
> {code}
> curl http://localhost:10090/metrics/vendor 2>/dev/null | grep loaded_modules
> # HELP vendor:loaded_modules Number of loaded modules
> # TYPE vendor:loaded_modules gauge
> vendor:loaded_modules 23.0
> {code}
> When I tried Thorntail 2 based deployment I got {{vendor:loaded_modules 298.0}}
> WF probably reports incorrect value for loaded modules.
> The same value is reported when I deploy {{quickstart/helloworld-rs/target/helloworld-rs.war}} application. For sure new modules are triggered by deplyment.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)