[jboss-jira] [JBoss JIRA] (WFLY-11165) Eliminate unessential module dependencies on the org.jboss.as.transactions module

[Brian Stansberry (Jira)]

    [ https://issues.jboss.org/browse/WFLY-11165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13659726#comment-13659726 ] 

Brian Stansberry commented on WFLY-11165:
-----------------------------------------

Hi [~ochaloup] -- with the work on WFLY-11166 and WFLY-11167, plus just cleaning out some unneeded dependencies on org.jboss.as.transactions, the "simple" part of this is done. If you'd like I can resolve this and further work can be in other tasks or in WFLY-9588, or if you'd like to take this over I can assign to you.

Here's are the remaining cases where modules are depending on org.jboss.as.transactions:

{code}
$ git grep org.jboss.as.transactions | grep module.xml
feature-pack/src/main/resources/modules/system/layers/base/javax/orb/api/main/module.xml:        <module name="org.jboss.as.transactions" optional="true"/>
feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/connector/main/module.xml:        <module name="org.jboss.as.transactions"/>
feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/ejb3/main/module.xml:        <module name="org.jboss.as.transactions"/>
feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/jpa/main/module.xml:        <module name="org.jboss.as.transactions"/>
feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/transactions/main/module.xml:<module xmlns="urn:jboss:module:1.5" name="org.jboss.as.transactions">
feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/xts/main/module.xml:        <module name="org.jboss.as.transactions"/>
feature-pack/src/main/resources/modules/system/layers/base/org/jboss/jts/integration/main/module.xml:        <module name="org.jboss.as.transactions">
feature-pack/src/main/resources/modules/system/layers/base/org/jboss/jts/main/module.xml:        <module name="org.jboss.as.transactions">
{code}

1) javax.orb.api is configured by the iiop subsystem to load classes from org.jboss.as.txn. Changing that would require refactoring the 'transactions' maven module to split those classes from the subsystem. Possible, if you think it's worth it; sounds like the kind of thing you are thinking about in WFLY-9588.

2) org.jboss.as.connector is importing a couple ServiceName constants; those should be capabilities a la WFLY-11167. There's also use of JBossContextXATerminator, but I suspect that could be converted to just JBossXATerminator.

3) org.jboss.as.ejb3 is using some service name constants that should be capabilities a la WFLY-11167, but it's also using UserTransactionAccessControlService and UserTransactionAccessControl.

4) org.jboss.as.jpa is using UserTransactionRegistryService.SERVICE_NAME. This should be a capability a la WFLY-11167.

5) org.jboss.as.xts uses org.jboss.as.txn.deployment.TransactionRollbackSetupAction

Of these, 2) and 4) sound like the kinds of things I talked about in the issue description. The others are cases where classes from the module really do need to be used, unless the module is refactored.

> Eliminate unessential module dependencies on the org.jboss.as.transactions module
> ---------------------------------------------------------------------------------
>
>                 Key: WFLY-11165
>                 URL: https://issues.jboss.org/browse/WFLY-11165
>             Project: WildFly
>          Issue Type: Enhancement
>          Components: Class Loading, Management, Transactions
>            Reporter: Brian Stansberry
>            Assignee: Brian Stansberry
>            Priority: Major
>
> As part of our work on getting maximum benefit from Galleon, we want to eliminate unnecessary hard dependencies between Galleon packages, most of which are just provisioning wrappers around the FS content for our  JBoss Modules modules.  So that means cutting dependency links between modules.
> The org.jboss.as.transactions module necessarily has a large dependency tree, so if other modules depend on it, they then also have a large dependency tree, perhaps much larger than whatever they really need.  So I want to eliminate such dependencies whereever possible.
> There are quite a few modules that depend on org.jboss.as.transactions solely for ServiceName constants for services that provide value types not from org.jboss.as.transactions,  e.g. TransactionManager which is from the javax.transaction.api module. So the main (perhaps only) task here will be to eliminate those links.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)