[jboss-jira] [JBoss JIRA] (DROOLS-3309) Code cleanup

Gabriele Cardosi (Jira) issues at jboss.org
Mon Nov 12 05:45:00 EST 2018


     [ https://issues.jboss.org/browse/DROOLS-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gabriele Cardosi updated DROOLS-3309:
-------------------------------------
    Description: 
Clean up code

# 1) replace GIVEN/EXPECT Strings with Enum
# 2) move classes to proper packages
# 3) remove get(0) used to set background color
# 4) remove injection of ScenarioSimulationDocksHandler from ScenarioSimulationEditorPresenter
## a) inject ScenarioSimulationDocksHandler inside CommandExecutor
## b) create one specific GWT event with four Enum to decide which action to execute 
## c) register CommandExecutor for that event
## d) inside ScenarioSimulationEditorPresenter fire the required event when necessary instead of direct calls top DocksHandler
## e) let CommandExecutor manage the event

  was:
Clean up code

1) replace GIVEN/EXPECT Strings with Enum
2) move classes to proper packages




> Code cleanup
> ------------
>
>                 Key: DROOLS-3309
>                 URL: https://issues.jboss.org/browse/DROOLS-3309
>             Project: Drools
>          Issue Type: Enhancement
>          Components: Scenario Simulation and Testing
>            Reporter: Gabriele Cardosi
>            Assignee: Gabriele Cardosi
>            Priority: Minor
>
> Clean up code
> # 1) replace GIVEN/EXPECT Strings with Enum
> # 2) move classes to proper packages
> # 3) remove get(0) used to set background color
> # 4) remove injection of ScenarioSimulationDocksHandler from ScenarioSimulationEditorPresenter
> ## a) inject ScenarioSimulationDocksHandler inside CommandExecutor
> ## b) create one specific GWT event with four Enum to decide which action to execute 
> ## c) register CommandExecutor for that event
> ## d) inside ScenarioSimulationEditorPresenter fire the required event when necessary instead of direct calls top DocksHandler
> ## e) let CommandExecutor manage the event



--
This message was sent by Atlassian Jira
(v7.12.1#712002)


More information about the jboss-jira mailing list