[jboss-jira] [JBoss JIRA] (DROOLS-3309) Code cleanup
Gabriele Cardosi (Jira)
issues at jboss.org
Mon Nov 12 05:58:00 EST 2018
[ https://issues.jboss.org/browse/DROOLS-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gabriele Cardosi updated DROOLS-3309:
-------------------------------------
Description:
Clean up code
# replace GIVEN/EXPECT Strings with Enum
# move classes to proper packages
# rename classes with "old" meanings (for ex, BaseExpressionGridTheme is the name of the class originally copied from DMN)
# BaseExpressionGridTheme.getHeaderBackground remove get(0) used to set background color
# remove injection of ScenarioSimulationDocksHandler from ScenarioSimulationEditorPresenter
## inject ScenarioSimulationDocksHandler inside CommandExecutor
## create one specific GWT event with four Enum to choose which action to execute
## register CommandExecutor for that event
## inside ScenarioSimulationEditorPresenter fire the required event when necessary instead of direct calls top DocksHandler
## let CommandExecutor manage the event
was:
Clean up code
# replace GIVEN/EXPECT Strings with Enum
# move classes to proper packages
# rename classes with "old" meanings (for ex, BaseExpressionGridTheme is the name of the class originally copied)
# BaseExpressionGridTheme.getHeaderBackground remove get(0) used to set background color
# remove injection of ScenarioSimulationDocksHandler from ScenarioSimulationEditorPresenter
## inject ScenarioSimulationDocksHandler inside CommandExecutor
## create one specific GWT event with four Enum to choose which action to execute
## register CommandExecutor for that event
## inside ScenarioSimulationEditorPresenter fire the required event when necessary instead of direct calls top DocksHandler
## let CommandExecutor manage the event
> Code cleanup
> ------------
>
> Key: DROOLS-3309
> URL: https://issues.jboss.org/browse/DROOLS-3309
> Project: Drools
> Issue Type: Enhancement
> Components: Scenario Simulation and Testing
> Reporter: Gabriele Cardosi
> Assignee: Gabriele Cardosi
> Priority: Minor
>
> Clean up code
> # replace GIVEN/EXPECT Strings with Enum
> # move classes to proper packages
> # rename classes with "old" meanings (for ex, BaseExpressionGridTheme is the name of the class originally copied from DMN)
> # BaseExpressionGridTheme.getHeaderBackground remove get(0) used to set background color
> # remove injection of ScenarioSimulationDocksHandler from ScenarioSimulationEditorPresenter
> ## inject ScenarioSimulationDocksHandler inside CommandExecutor
> ## create one specific GWT event with four Enum to choose which action to execute
> ## register CommandExecutor for that event
> ## inside ScenarioSimulationEditorPresenter fire the required event when necessary instead of direct calls top DocksHandler
> ## let CommandExecutor manage the event
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
More information about the jboss-jira
mailing list