[jboss-jira] [JBoss JIRA] (WFWIP-148) Artemis logging codes/IDs have changed for CORE protocol

[Dimitris Andreadis (Jira)]

    [ https://issues.jboss.org/browse/WFWIP-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13664215#comment-13664215 ] 

Dimitris Andreadis commented on WFWIP-148:
------------------------------------------

[~jbertram], Error codes, Configuration, Scripts are pretty much part of a product's public "API". Changing Error codes of course is not a "bug" in the code sense, but it could potentially break the monitoring of a deployment, tied to some related action. Or else how can you ensure smooth upgrades? Changed error codes can indeed be worse than duplicated ones in the sense that the former can go undetected during an upgrade while the latter it is a known problematic state.

So to clarify, this change was made going from AMQ 7.2.1 to 7.2.2?

In any case, we definitely don't want to fork because of it, so since according to your thinking it shouldn't be a big things for customers in general, why not swapping the error codes in AMQ 7.2.3 to keep the CORE ones used in EAP stable, instead? EAP has more customers who are likely more picky than AMQ when it comes to compatibility issues.

> Artemis logging codes/IDs have changed for CORE protocol
> --------------------------------------------------------
>
>                 Key: WFWIP-148
>                 URL: https://issues.jboss.org/browse/WFWIP-148
>             Project: WildFly WIP
>          Issue Type: Bug
>          Components: Artemis
>            Reporter: Miroslav Novak
>            Assignee: Justin Bertram
>            Priority: Blocker
>
> Artemis logging codes for CORE protocol has changed in scope of jira: https://issues.apache.org/jira/browse/ARTEMIS-1018
> For example in WF14 if standalone JMS client failed to connect then it was logged with code AMQ119007:
> {code}
> Caused by: ActiveMQNotConnectedException[errorType=NOT_CONNECTED message=AMQ119007: Cannot connect to server(s). Tried with all available servers.]
> {code}
> but newly it would have code AMQ219007:
> {code}
> Caused by: ActiveMQNotConnectedException[errorType=NOT_CONNECTED message=AMQ219007: Cannot connect to server(s). Tried with all available servers.]
> {code}
> This is problem for any user/customer who had monitoring based on those codes as this will require to change it.
> The reason for change was because those codes were duplicated between AMQP and CORE protocol. As CORE protocol is default and AMQP is not supported for EAP ti would makes sense to change AMQP codes instead and keep codes for CORE protocol without any change. 



--
This message was sent by Atlassian Jira
(v7.12.1#712002)