[jboss-jira] [JBoss JIRA] (WFWIP-148) Artemis logging codes/IDs have changed for CORE protocol

Jeff Mesnil (Jira) issues at jboss.org
Wed Nov 21 02:55:00 EST 2018


    [ https://issues.jboss.org/browse/WFWIP-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13664365#comment-13664365 ] 

Jeff Mesnil commented on WFWIP-148:
-----------------------------------

Could we simply hard-code the old value in the message associated to the new value until the next major release?
For example:

{code}
@Message(id = 139000, value = "AMQ129000: Invalid filter: {0}", format = Message.Format.MESSAGE_FORMAT)
    ActiveMQInvalidFilterExpressionException invalidFilter(@Cause Throwable e, SimpleString filter);		    ActiveMQInvalidFilterExpressionException invalidFilter(@Cause Throwable e, SimpleString filter);
{code}

This would log the message with the new (correct) and old (duplicated) value:

{code}
18:59:56,722 INFO  [org.apache.activemq.artemis.ra] (ServerService Thread Pool -- 86) AMQ139000: AMQ129000: invalid filter: foo=bar"
{code}


> Artemis logging codes/IDs have changed for CORE protocol
> --------------------------------------------------------
>
>                 Key: WFWIP-148
>                 URL: https://issues.jboss.org/browse/WFWIP-148
>             Project: WildFly WIP
>          Issue Type: Bug
>          Components: Artemis
>            Reporter: Miroslav Novak
>            Assignee: Justin Bertram
>            Priority: Blocker
>
> Artemis logging codes for CORE protocol has changed in scope of jira: https://issues.apache.org/jira/browse/ARTEMIS-1018
> For example in WF14 if standalone JMS client failed to connect then it was logged with code AMQ119007:
> {code}
> Caused by: ActiveMQNotConnectedException[errorType=NOT_CONNECTED message=AMQ119007: Cannot connect to server(s). Tried with all available servers.]
> {code}
> but newly it would have code AMQ219007:
> {code}
> Caused by: ActiveMQNotConnectedException[errorType=NOT_CONNECTED message=AMQ219007: Cannot connect to server(s). Tried with all available servers.]
> {code}
> This is problem for any user/customer who had monitoring based on those codes as this will require to change it.
> The reason for change was because those codes were duplicated between AMQP and CORE protocol. As CORE protocol is default and AMQP is not supported for EAP ti would makes sense to change AMQP codes instead and keep codes for CORE protocol without any change. 



--
This message was sent by Atlassian Jira
(v7.12.1#712002)


More information about the jboss-jira mailing list