[jboss-jira] [JBoss JIRA] (WFCORE-4206) Elytron extension module has un-used optional dependency

[Yeray Borges (Jira)]

    [ https://issues.jboss.org/browse/WFCORE-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13665589#comment-13665589 ] 

Yeray Borges edited comment on WFCORE-4206 at 11/23/18 9:13 AM:
----------------------------------------------------------------

I was going to create the PR, but some loadClass methods in the Elytron subsystem make me a bit reluctant.

CustomComponentDefinition, JaspiDefinition and CustomPolicyDefinition could load classes using org.wildfly.extension.elytron module, so I'm not sure if a class visible to this module is subcetible of contain code that works procesing annotations included in javax.annotation.api.

I found this module was added [here|https://github.com/wildfly-security/elytron-subsystem/commit/251f1591d442bc66f996f04931123c4df0be5964#diff-a6e596af18b80d8481526f285a00c121R31] and removed [here|https://github.com/wildfly-security/elytron-subsystem/commit/f8825577c9e475eb646de76aabd7ca589c20c502#diff-a6e596af18b80d8481526f285a00c121L31], it is the old branch used for elytron integration so probably we can safely remove it. I don't know why the removal was not mirrored in wildfly-core.

[~dlofthouse], based on the above, could you confirm if we can remove javax.annotation.api from org.wildfly.extension.elytron?



was (Author: yersan):
I was going to create the PR, but some loadClass methods in the Elytron subsystem make me a bit reluctant.

CustomComponentDefinition, JaspiDefinition and CustomPolicyDefinition could load classes using org.wildfly.extension.elytron module, so I'm not sure if a class visible to this module is subcetible of contain code that works procesing annotations included in javax.annotation.api.

I found this module was added [here|https://github.com/wildfly-security/elytron-subsystem/commit/251f1591d442bc66f996f04931123c4df0be5964#diff-a6e596af18b80d8481526f285a00c121R31] and removed [here|https://github.com/wildfly-security/elytron-subsystem/commit/f8825577c9e475eb646de76aabd7ca589c20c502#diff-a6e596af18b80d8481526f285a00c121L31], it is the old branch used for elytron integration so probable we can safely remove it.I don't know whay the removal was not mirrored in wildfly-core.

[~dlofthouse], based on the above, could you confirm if we can remove javax.annotation.api from org.wildfly.extension.elytron?


> Elytron extension module has un-used optional dependency
> --------------------------------------------------------
>
>                 Key: WFCORE-4206
>                 URL: https://issues.jboss.org/browse/WFCORE-4206
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Security
>            Reporter: Jean-Francois Denise
>            Assignee: Yeray Borges
>            Priority: Minor
>
> javax.annotation.api doesn't seem use by the module. Optional dep could be removed.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)