[jboss-jira] [JBoss JIRA] (WFWIP-141) Vendor metrics - subsystem - statistics-enabled to get valid data

[Jeff Mesnil (Jira)]

    [ https://issues.jboss.org/browse/WFWIP-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13666078#comment-13666078 ] 

Jeff Mesnil commented on WFWIP-141:
-----------------------------------

The metrics subsystem ignores WildFly metrics that have undefined value (e.g. if their statistics-enabled that controls them is false)
This ensures that the subsystem only reports actual metric value (otherwise we have to open bugs to fix it).

Standalone configs could be further enhanced by using a global env var to enable the statistics from the subsystems that reports such metrics (undertow, messaging-activemq, etc.)

> Vendor metrics - subsystem - statistics-enabled to get valid data
> -----------------------------------------------------------------
>
>                 Key: WFWIP-141
>                 URL: https://issues.jboss.org/browse/WFWIP-141
>             Project: WildFly WIP
>          Issue Type: Bug
>          Components: MP Metrics
>            Reporter: Rostislav Svoboda
>            Assignee: Jeff Mesnil
>            Priority: Critical
>
> Vendor metrics - subsystem - statistics-enabled to get valid data
> I was playing with vendor metrics and I received a lot of zeros.
> {code}
> curl http://localhost:10090/metrics/vendor 2>/dev/null | grep -v TYPE | grep -v HELP | sort
> {code}
> Note: I use {{-Djboss.socket.binding.port-offset=100}}
> So I started to wonder why and it's because of statistics are not enabled.
> When I enabled statistics for Undertow and hit the WF server main page I saw some changes in metrics.
> {code}
> subsystem=undertow/:write-attribute(name=statistics-enabled, value=true)
> {code}
> Later I realized this scenario is also mentioned in analysis, section WildFly Metrics with undefined value / statistic-enabled = false
> https://github.com/wildfly/wildfly-proposals/blob/cc189b56720951875aa96102f876ac0399930f9c/microprofile/WFLY-10712_microprofile_metrics.asciidoc#wildfly-metrics-with-undefined-value--statistic-enabled--false
> So this is mainly tracking + discussion point now.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)