[jboss-jira] [JBoss JIRA] (WFWIP-130) SmallRye Metrics - JmxWorker - findKeyForValueToBeReplaced could use some polish

[Jeff Mesnil (Jira)]

    [ https://issues.jboss.org/browse/WFWIP-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13666086#comment-13666086 ] 

Jeff Mesnil commented on WFWIP-130:
-----------------------------------

Reported upstream at https://github.com/smallrye/smallrye-metrics/issues/35

> SmallRye Metrics - JmxWorker - findKeyForValueToBeReplaced could use some polish
> --------------------------------------------------------------------------------
>
>                 Key: WFWIP-130
>                 URL: https://issues.jboss.org/browse/WFWIP-130
>             Project: WildFly WIP
>          Issue Type: Bug
>          Components: MP Metrics
>            Reporter: Rostislav Svoboda
>            Assignee: Jeff Mesnil
>            Priority: Major
>
> SmallRye Metrics - JmxWorker - findKeyForValueToBeReplaced could use some polish
> https://github.com/smallrye/smallrye-metrics/blob/master/implementation/src/main/java/io/smallrye/metrics/JmxWorker.java#L156
>  - iterate entrySet instead of keySet
>  - can it happen that there are more entries with value '*' ?
>  - shouldn't the for cycle end when the (first?) match is found ?



--
This message was sent by Atlassian Jira
(v7.12.1#712002)