[jboss-jira] [JBoss JIRA] (WFLY-10531) Wildfly leaks ActiveMQ connections

[Jiri Ondrusek (Jira)]

    [ https://issues.jboss.org/browse/WFLY-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13642261#comment-13642261 ] 

Jiri Ondrusek commented on WFLY-10531:
--------------------------------------

[~jwgmeligmeyling] Hi, I'm also wondering why is it happening at first place. 

But I have manually tested this new patch with both reproducers (from [~gunterze] and older reproducer for https://issues.jboss.org/browse/WFLY-9501) Both were working successfully.

Her are some "well known" facts:
* If close is executed in PreDestroy for all cases -> there is no error with new reproducer (but old reproducer fails, which is obvious - it's a revert of original fix)
* I've also tried to keep closing in PreDestroy for all cases + add transaction listener, so inTx contexts were closed twice - this should not be used, but I've tried it to validate reason - there were no error with both reproducers - so it also worked
* then I accidentally forgot one negation in my new patch. It caused, that contexts from inTx were closed twice, but without inTx weren't close at all. (I have validated it with some debugging messages) - there was an error with new reproducer.

>From the third item, I was able to see (because of my debugging messages), that there are contexts which are injected and not inTx (which sounds possible) - and these contexts are  not closed with original fix -> *this is the reason of the current issue*

I'm currently trying to rewrite new reproducer into integration test to add certainty, that fix works - unfortunately, I'm still not able to reproduce an error in test, but I hope that it should be possible. 


> Wildfly leaks ActiveMQ connections
> ----------------------------------
>
>                 Key: WFLY-10531
>                 URL: https://issues.jboss.org/browse/WFLY-10531
>             Project: WildFly
>          Issue Type: Bug
>    Affects Versions: 13.0.0.Final
>         Environment: openjdk 8 / openjdk 9, Linux
>            Reporter: Marcel Šebek
>            Assignee: Jeff Mesnil
>            Priority: Major
>         Attachments: WFLY-10531-ear-1.0.ear, WFLY10531.zip
>
>
> After upgrading our application from wildfly 12 to 13, the app started to crash after a while (hours, days, depending on circumstances). It crashes on
> IJ000453: Unable to get managed connection for java:/JmsXA
> and other errors (it simply cannot perform all the jobs it contains). I found that when shutting down the server which has been running for a while, I can see a bunch of these messages in the log:
> WARN  [org.jboss.jca.core.connectionmanager.pool.strategy.PoolByCri] (ServerService Thread Pool -- 117) [:::] IJ000615: Destroying active connection in pool: ActiveMQConnectionDefinition (org.apache.activemq.artemis.ra.ActiveMQRAManagedConnection at 2f37f69)
> Bascially, the longer the server was running, more of these messages are shown. I cannot find a way how to reproduce the issue. When the server runs for short time but with some load, no connection is leaked (or just one, rarely). On the other side, it leaks connections even without any particularly high load (just a few requests and @Schedule jobs) when running for longer time.
> It may also be a bug in our application, which just happen to have more serious impact with the new wildfly version.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)