[jboss-jira] [JBoss JIRA] (DROOLS-3081) Modify CustomPopup for extended usage/usability

[Michael Anstis (Jira)]

    [ https://issues.jboss.org/browse/DROOLS-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643612#comment-13643612 ] 

Michael Anstis commented on DROOLS-3081:
----------------------------------------

[~gabriolo] Making these changes and then extending the class for your use-case is probably (a) just as simple as copying and pasting the code (as you've done), (b) will improve re-usability for others, (c) be less of a maintenance concern later on. IDK why you cannot make these changes as part of DROOLS-3053 - we often have PRs spanning multiple repositories for a JIRA.

> Modify CustomPopup for extended usage/usability
> -----------------------------------------------
>
>                 Key: DROOLS-3081
>                 URL: https://issues.jboss.org/browse/DROOLS-3081
>             Project: Drools
>          Issue Type: Task
>            Reporter: Gabriele Cardosi
>            Assignee: Gabriele Cardosi
>            Priority: Optional
>
> Currently, https://github.com/kiegroup/appformer/blob/master/uberfire-workbench/uberfire-workbench-client-views-patternfly/src/main/java/org/uberfire/client/views/pfly/widgets/ConfirmPopup.java allows only a "OK/Cancel" behaviour; moreover, due to access modifiers used for its properties, and the lack of accessors to them, it is impossible to extend it.
> What it is required is:
> 1) change modifiers/accessors, so to have make it "extendable"
> 2) insert code to allow also a "YES/NO/Cancel" behavior, as implemented with https://issues.jboss.org/browse/DROOLS-3053



--
This message was sent by Atlassian Jira
(v7.12.1#712002)